Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: support secure cookie storage for nuxt sdk #794

Merged
merged 1 commit into from
Sep 18, 2024
Merged

feat!: support secure cookie storage for nuxt sdk #794

merged 1 commit into from
Sep 18, 2024

Conversation

xiaoyijun
Copy link
Contributor

Summary

Support secure cookie storage for nuxt sdk, since the default CookieStorage behavior has changed in #783

Testing

Test locally.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@xiaoyijun xiaoyijun requested a review from a team September 14, 2024 02:40
@xiaoyijun xiaoyijun self-assigned this Sep 14, 2024
@xiaoyijun xiaoyijun force-pushed the xiaoyijun-support-secure-cookie-storage-for-nuxt-sdk branch 2 times, most recently from 54e7b8b to 8c8ea1f Compare September 14, 2024 02:47
@xiaoyijun xiaoyijun marked this pull request as ready for review September 14, 2024 02:47
@xiaoyijun xiaoyijun changed the title feat: support secure cookie storage for nuxt sdk feat!: support secure cookie storage for nuxt sdk Sep 14, 2024
@xiaoyijun xiaoyijun force-pushed the xiaoyijun-support-secure-cookie-storage-for-nuxt-sdk branch from 8c8ea1f to a61073c Compare September 14, 2024 03:12
wangsijie
wangsijie reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@wangsijie wangsijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can still use auto detection to get isSecure value on Nuxt side, this can avoid breaking change

@xiaoyijun xiaoyijun merged commit 5f4de8c into master Sep 18, 2024
20 checks passed
@xiaoyijun xiaoyijun deleted the xiaoyijun-support-secure-cookie-storage-for-nuxt-sdk branch September 18, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangsijie wangsijie wangsijie left review comments

@charIeszhao charIeszhao charIeszhao approved these changes

Assignees

@xiaoyijun xiaoyijun

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoyijun @wangsijie @charIeszhao