Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-sample): add sso direct sign-in landing page #799

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat(react-sample): add sso direct sign-in landing page #799

wants to merge 2 commits into from
+37 −2

Conversation

simeng-li
Copy link
Contributor

@simeng-li simeng-li commented Sep 27, 2024 •
edited
Loading

Summary

Add SSO direct sign-in landing page to the react-sample project.

Testing

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

wangsijie
wangsijie approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@wangsijie wangsijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in PR description.

charIeszhao
charIeszhao approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@charIeszhao charIeszhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with nit comments

@simeng-li simeng-li force-pushed the simeng-react-direct-sign-in-url branch from e1c9091 to fe4dc0a Compare October 17, 2024 07:33
@simeng-li simeng-li marked this pull request as draft October 17, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charIeszhao charIeszhao charIeszhao approved these changes

@wangsijie wangsijie wangsijie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simeng-li @wangsijie @charIeszhao