fix: catch uncaught errors in express middleware so they can be passed onwards to the express error handler #913
+14
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the withLogto middleware does not have a try catch block which sometimes leads to uncaught errors and middleware limbo with the request hanging. This PR fixes it by wrapping all the middleware logic in a try/catch block to ensure errors are caught appropriately and they are passed onwards to the next middleware which can be a custom error handler, etc. depending on the user and application.
Testing
I made the changes locally and tried it with my application and the hanging issues were resolved as the error was now able to be caught and handled.
Checklist
.changeset
- Not sure