fix(console): do not show unsaved alert after delete connector (#1496)

logto-io · Jul 8, 2022 · 61a6b1a · 61a6b1a
1 parent 58558e5
commit 61a6b1a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/console/src/pages/ConnectorDetails/components/ConnectorContent.tsx b/packages/console/src/pages/ConnectorDetails/components/ConnectorContent.tsx
@@ -14,11 +14,12 @@ import * as styles from '../index.module.scss';
 import SenderTester from './SenderTester';
 
 type Props = {
+ isDeleted: boolean;
  connectorData: ConnectorDTO;
  onConnectorUpdated: (connector: ConnectorDTO) => void;
 };
 
-const ConnectorContent = ({ connectorData, onConnectorUpdated }: Props) => {
+const ConnectorContent = ({ isDeleted, connectorData, onConnectorUpdated }: Props) => {
  const { t } = useTranslation(undefined, { keyPrefix: 'admin_console' });
  const [config, setConfig] = useState<string>();
  const [isSubmitting, setIsSubmitting] = useState(false);
@@ -116,7 +117,7 @@ const ConnectorContent = ({ connectorData, onConnectorUpdated }: Props) => {
  />
  </div>
  </div>
- <UnsavedChangesAlertModal hasUnsavedChanges={hasUnsavedChanges} />
+ <UnsavedChangesAlertModal hasUnsavedChanges={!isDeleted && hasUnsavedChanges} />
  </>
  );
 };

diff --git a/packages/console/src/pages/ConnectorDetails/index.tsx b/packages/console/src/pages/ConnectorDetails/index.tsx
@@ -35,6 +35,7 @@ import * as styles from './index.module.scss';
 const ConnectorDetails = () => {
  const { connectorId } = useParams();
  const { mutate: mutateGlobal } = useSWRConfig();
+ const [isDeleted, setIsDeleted] = useState(false);
  const [isReadMeOpen, setIsReadMeOpen] = useState(false);
  const [isSetupOpen, setIsSetupOpen] = useState(false);
  const { t } = useTranslation(undefined, { keyPrefix: 'admin_console' });
@@ -60,6 +61,7 @@ const ConnectorDetails = () => {
  toast.success(t('connector_details.connector_deleted'));
 
  await mutateGlobal('/api/connectors');
+ setIsDeleted(true);
 
  if (data?.type === ConnectorType.Social) {
  navigate(`/connectors/social`, { replace: true });
@@ -169,6 +171,7 @@ const ConnectorDetails = () => {
  </TabNavItem>
  </TabNav>
  <ConnectorContent
+ isDeleted={isDeleted}
  connectorData={data}
  onConnectorUpdated={(connector) => {
  void mutate(connector);