fix: rename auto_code to code

logto-io · May 24, 2024 · a151f48 · a151f48
1 parent c67acaa
commit a151f48
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 12 deletions.
diff --git a/packages/connectors/connector-dingtalk-web/src/constant.ts b/packages/connectors/connector-dingtalk-web/src/constant.ts
@@ -6,11 +6,6 @@ export const accessTokenEndpoint = 'https://api.dingtalk.com/v1.0/oauth2/userAcc
 export const userInfoEndpoint = 'https://api.dingtalk.com/v1.0/contact/users/me';
 export const scope = 'openid corpid';
 
-// See https://open.dingtalk.com/document/orgapp/obtain-identity-credentials to know more about WeChat response error code
-export const invalidAuthCodeErrcode = [40_029, 40_163, 42_003];
-
-export const invalidAccessTokenErrcode = [40_001, 40_014];
-
 export const defaultMetadata: ConnectorMetadata = {
   id: 'dingtalk-web',
   target: 'dingtalk',

diff --git a/packages/connectors/connector-dingtalk-web/src/index.test.ts b/packages/connectors/connector-dingtalk-web/src/index.test.ts
@@ -93,7 +93,7 @@ describe('Dingtalk connector', () => {
       const connector = await createConnector({ getConfig });
       const socialUserInfo = await connector.getUserInfo(
         {
-          auth_code: 'code',
+          code: 'code',
         },
         vi.fn()
       );
@@ -117,23 +117,23 @@ describe('Dingtalk connector', () => {
     it('throws SocialAccessTokenInvalid error if remote response code is 401', async () => {
       nock(userInfoEndpoint).get('').reply(401);
       const connector = await createConnector({ getConfig });
-      await expect(connector.getUserInfo({ auth_code: 'code' }, vi.fn())).rejects.toStrictEqual(
+      await expect(connector.getUserInfo({ code: 'code' }, vi.fn())).rejects.toStrictEqual(
         new ConnectorError(ConnectorErrorCodes.SocialAccessTokenInvalid)
       );
     });
 
     it('throws right accessToken but empty userInfo if remote response code is 404', async () => {
       nock(userInfoEndpoint).get('').reply(404);
       const connector = await createConnector({ getConfig });
-      await expect(connector.getUserInfo({ auth_code: 'code' }, vi.fn())).rejects.toStrictEqual(
+      await expect(connector.getUserInfo({ code: 'code' }, vi.fn())).rejects.toStrictEqual(
         new ConnectorError(ConnectorErrorCodes.InvalidResponse, 'user_not_found')
       );
     });
 
     it('throws unrecognized error', async () => {
       nock(userInfoEndpoint).get('').reply(500);
       const connector = await createConnector({ getConfig });
-      await expect(connector.getUserInfo({ auth_code: 'code' }, vi.fn())).rejects.toThrow();
+      await expect(connector.getUserInfo({ code: 'code' }, vi.fn())).rejects.toThrow();
     });
   });
 });
diff --git a/packages/connectors/connector-dingtalk-web/src/index.ts b/packages/connectors/connector-dingtalk-web/src/index.ts
@@ -88,10 +88,10 @@ export const getAccessToken = async (
 const getUserInfo =
   (getConfig: GetConnectorConfig): GetUserInfo =>
   async (data) => {
-    const { auth_code } = await authorizationCallbackHandler(data);
+    const { code } = await authorizationCallbackHandler(data);
     const config = await getConfig(defaultMetadata.id);
     validateConfig(config, dingtalkConfigGuard);
-    const { accessToken } = await getAccessToken(auth_code, config);
+    const { accessToken } = await getAccessToken(code, config);
 
     try {
       const httpResponse = await got.get(userInfoEndpoint, {

diff --git a/packages/connectors/connector-dingtalk-web/src/types.ts b/packages/connectors/connector-dingtalk-web/src/types.ts
@@ -33,4 +33,4 @@ export type UserInfoResponse = z.infer<typeof userInfoResponseGuard>;
 
 export type UserInfoResponseMessageParser = (userInfo: Partial<UserInfoResponse>) => void;
 
-export const authResponseGuard = z.object({ auth_code: z.string() });
+export const authResponseGuard = z.object({ code: z.string() });
Original file line number	Diff line number	Diff line change
Expand Up		@@ -33,4 +33,4 @@ export type UserInfoResponse = z.infer<typeof userInfoResponseGuard>;

		export type UserInfoResponseMessageParser = (userInfo: Partial<UserInfoResponse>) => void;

		export const authResponseGuard = z.object({ auth_code: z.string() });
		export const authResponseGuard = z.object({ code: z.string() });