Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): disable secondary should remove sign in methods #1384

Merged
merged 1 commit into from
Jul 3, 2022
Merged

fix(console): disable secondary should remove sign in methods #1384

merged 1 commit into from
Jul 3, 2022

Conversation

wangsijie
Copy link
Contributor

Summary

When disable secondary sign in, all other methods should be set to "disabled".

Testing

截屏2022-07-03 下午10 22 11

@linear
Copy link

linear bot commented Jul 3, 2022

LOG-3355 关闭其他登录方式后，Preview 没有反应

@github-actions
Copy link

github-actions bot commented Jul 3, 2022

COMPARE TO master

Total Size Diff 📈 +84 Bytes

Diff by File
Name Diff
packages/console/src/pages/SignInExperience/utilities.ts 📈 +84 Bytes

IceHe
IceHe approved these changes Jul 3, 2022
View reviewed changes
Copy link
Contributor

@IceHe IceHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gao-sun gao-sun merged commit 6e3c461 into master Jul 3, 2022
@gao-sun gao-sun deleted the sijie-log-3355-disable-secondary branch July 3, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceHe IceHe IceHe approved these changes

@gao-sun gao-sun gao-sun approved these changes

@darcyYe darcyYe darcyYe approved these changes

@xiaoyijun xiaoyijun Awaiting requested review from xiaoyijun xiaoyijun is a code owner

@charIeszhao charIeszhao Awaiting requested review from charIeszhao charIeszhao is a code owner

@simeng-li simeng-li Awaiting requested review from simeng-li

Assignees

@wangsijie wangsijie

Labels
bugfix size/xs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangsijie @IceHe @gao-sun @darcyYe