Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): append additional yaml responses to swagger.json #1407

Merged

Conversation

IceHe
Copy link
Contributor

@IceHe IceHe commented Jul 4, 2022

Summary

Append the additional YAML OpenAPI responses content to swagger.json

Testing

image

image

image

@linear
Copy link

linear bot commented Jul 4, 2022

LOG-2993 Custom the response status code

See Slack thread discussion

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

COMPARE TO master

Total Size Diff 📈 +3.09 KB

Diff by File
Name Diff
packages/core/package.json 📈 +57 Bytes
packages/core/src/routes/swagger.test.ts 📈 +2 KB
packages/core/src/routes/swagger.ts 📈 +743 Bytes
packages/core/static/yaml/additional-swagger.yaml 📈 +1.38 KB
pnpm-lock.yaml 📈 +1.07 KB

@github-actions github-actions bot added the feature Cool stuff label Jul 4, 2022
@IceHe IceHe force-pushed the icehe-log-2993-custom-response-status-code-in-swagger-json branch from 01d0f5c to 37bede6 Compare July 4, 2022 11:08
@github-actions github-actions bot added the size/m label Jul 4, 2022
@IceHe IceHe marked this pull request as draft July 4, 2022 16:57
@IceHe IceHe changed the title feat(core): custom status code in swagger.json feat(core): append additional content to swagger.json Jul 6, 2022
@IceHe IceHe changed the title feat(core): append additional content to swagger.json feat(core): append additional yaml content to swagger.json Jul 6, 2022
@IceHe IceHe force-pushed the icehe-log-2993-custom-response-status-code-in-swagger-json branch 2 times, most recently from 4c1fa55 to 8f240b4 Compare July 6, 2022 11:18
@IceHe IceHe marked this pull request as ready for review July 6, 2022 11:18
@IceHe IceHe requested a review from gao-sun July 6, 2022 11:19
packages/core/src/routes/swagger.ts Outdated Show resolved Hide resolved
packages/core/src/routes/swagger.ts Outdated Show resolved Hide resolved
@IceHe IceHe force-pushed the icehe-log-2993-custom-response-status-code-in-swagger-json branch from 8f240b4 to 87dedd4 Compare July 6, 2022 13:42
@IceHe IceHe requested a review from gao-sun July 6, 2022 14:35
Copy link
Contributor

@wangsijie wangsijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but don't have much background knowledge on this, better wait for another stamp.

@IceHe IceHe changed the title feat(core): append additional yaml content to swagger.json feat(core): append additional yaml responses to swagger.json Jul 7, 2022
Copy link
Member

@gao-sun gao-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

packages/core/src/routes/swagger.ts Outdated Show resolved Hide resolved
packages/core/src/routes/swagger.ts Outdated Show resolved Hide resolved
packages/core/src/routes/swagger.ts Outdated Show resolved Hide resolved
@IceHe IceHe enabled auto-merge (squash) July 7, 2022 09:42
@IceHe IceHe merged commit 100bffb into master Jul 7, 2022
@IceHe IceHe deleted the icehe-log-2993-custom-response-status-code-in-swagger-json branch July 7, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants