fix(console): save sie when secondary method is disabled #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/pages/SignInExperience/components/SignInMethodsForm.tsx | 📈 +166 Bytes |
gao-sun
requested review from
simeng-li,
wangsijie,
darcyYe,
charIeszhao,
IceHe and
xiaoyijun
charIeszhao
reviewed
Jul 4, 2022
packages/console/src/pages/SignInExperience/components/SignInMethodsForm.tsx
Show resolved
Hide resolved
charIeszhao
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix sie cannot save when secondary sign-in methods are disabled
the required rule will fail if
checkedis falseref react-hook-form/react-hook-form#2323
Testing
save successfully when secondary sign-in methods are disabled