Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): pagination color should be color-text-link #1466

Merged
merged 1 commit into from
Jul 7, 2022
Merged

fix(console): pagination color should be color-text-link #1466

merged 1 commit into from
Jul 7, 2022

Conversation

xiaoyijun
Copy link
Contributor

Summary

pagination active color should be var(--color-text-link)

Testing

image

@linear
Copy link

linear bot commented Jul 7, 2022

LOG-3408 Fix Pagination Color

截屏2022-07-04 上午11.19.04.png

截屏2022-07-04 上午11.24.12.png

参考 secondary button的方案

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

COMPARE TO master

Total Size Diff 📈 +4 Bytes

Diff by File
Name Diff
packages/console/src/components/Pagination/index.module.scss 📈 +4 Bytes

@xiaoyijun xiaoyijun enabled auto-merge (squash) July 7, 2022 16:52
@xiaoyijun xiaoyijun changed the title fix(console): pagination color fix(console): pagination color should be color-text-link Jul 7, 2022
@xiaoyijun xiaoyijun disabled auto-merge July 7, 2022 16:53
@xiaoyijun xiaoyijun enabled auto-merge (squash) July 7, 2022 16:53
IceHe
IceHe approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@IceHe IceHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoyijun xiaoyijun merged commit 481b6a0 into master Jul 7, 2022
@xiaoyijun xiaoyijun deleted the xiaoyijun-log-3408-fix-pagination-color branch July 7, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceHe IceHe IceHe approved these changes

@wangsijie wangsijie Awaiting requested review from wangsijie wangsijie is a code owner

@charIeszhao charIeszhao Awaiting requested review from charIeszhao charIeszhao is a code owner

@gao-sun gao-sun Awaiting requested review from gao-sun gao-sun is a code owner

@darcyYe darcyYe Awaiting requested review from darcyYe

@simeng-li simeng-li Awaiting requested review from simeng-li

Assignees

@xiaoyijun xiaoyijun

Labels
bugfix size/xs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoyijun @IceHe