Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): support crypto.getRandomValues in connectors #3744

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Apr 23, 2023

Summary

crypto is not natively supported by @AWS-SDK.
uuidjs/uuid#544

Testing

Tested locally. Do not throw an error telling that getRandomValues not supported.
Before fix:
image
After fix:
image

Checklist

  • .changeset
  • unit tests
  • integration tests
  • docs

OR

  • This PR is not applicable for the checklist

@github-actions
Copy link

github-actions bot commented Apr 23, 2023

COMPARE TO master

Total Size Diff 📈 +30 Bytes

Diff by File
Name Diff
packages/connectors/templates/preset/rollup.config.js 📈 +30 Bytes

@darcyYe darcyYe force-pushed the yemq-fix-aws-ses-getRandomValues-not-supported branch from d80bb82 to 354827f Compare April 23, 2023 13:41
@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Apr 23, 2023

Uffizzi Ephemeral Environment deployment-23074

⌚ Updated Apr 24, 2023, 08:17 UTC

☁️ https://app.uffizzi.com/github.com/logto-io/logto/pull/3744

📄 View Application Logs etc.

What is Uffizzi? Learn more

@darcyYe darcyYe changed the title fix(connector): AWS SES getRandomValues not supported fix(connector): support crypto.getRandomValues in connectors Apr 24, 2023
@darcyYe darcyYe force-pushed the yemq-fix-aws-ses-getRandomValues-not-supported branch from 354827f to d059b03 Compare April 24, 2023 06:07
@gao-sun gao-sun enabled auto-merge (squash) April 24, 2023 08:07
@gao-sun gao-sun merged commit 3c0477a into master Apr 24, 2023
@gao-sun gao-sun deleted the yemq-fix-aws-ses-getRandomValues-not-supported branch April 24, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants