Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): postmark email connector #5886

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

srs
Copy link
Contributor

@srs srs commented May 16, 2024

Summary

Implemented a Postmark email connector that uses Postmark API rather than SMTP. This provides the ability to use templates stored in Postmark instead of the templates stored in JSON.

This is implemented by looking at connector-sendgrid-email and implemented it as my understanding of best practices and convensions.

Testing

Have a simple uint-test that only checks configuration is valid (as also connector-sendgrid-email has). Else I did manual testing by connecting it in Logto UI and sending a test email trough the UI. Have also tested it in real-world scenarios by connecting it to an email provider.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented May 16, 2024

COMPARE TO master

Total Size Diff ⚠️ 📈 +26.48 KB

Diff by File
Name Diff
.changeset/bright-carpets-relax.md 📈 +67 Bytes
packages/connectors/connector-postmark/README.md 📈 +1.98 KB
packages/connectors/connector-postmark/logo.svg 📈 +2.26 KB
packages/connectors/connector-postmark/package.json 📈 +1.88 KB
packages/connectors/connector-postmark/src/constant.ts 📈 +1.34 KB
packages/connectors/connector-postmark/src/index.test.ts 📈 +1.18 KB
packages/connectors/connector-postmark/src/index.ts 📈 +1.67 KB
packages/connectors/connector-postmark/src/mock.ts 📈 +573 Bytes
packages/connectors/connector-postmark/src/types.ts 📈 +1002 Bytes
pnpm-lock.yaml ⚠️ 📈 +14.56 KB

@srs
Copy link
Contributor Author

srs commented May 16, 2024

This solves #5885.

@simeng-li
Copy link
Contributor

@wangsijie @darcyYe can you guys take a look thx.

Copy link
Contributor

@wangsijie wangsijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could you add some basic test cases?

@wangsijie
Copy link
Contributor

Also, it would be nice if you can make the commits signed.

@srs
Copy link
Contributor Author

srs commented May 17, 2024

I will add some basic tests and do signed commits.

@charIeszhao
Copy link
Member

charIeszhao commented May 29, 2024

Hey just ask our designer to create a logo for you.

logo

@charIeszhao
Copy link
Member

The pnpm lockfile seems to be corrupted. Please try to resolve this issue in order to pass the CI checks.

Usually this can be resolved by running pnpm i

@ErickLuis00
Copy link

@srs

Copy link

github-actions bot commented Jul 2, 2024

This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Jul 2, 2024
@srs
Copy link
Contributor Author

srs commented Jul 5, 2024

Sorry for this. Will be right on it after my vacation that ends in 4 days :)

@github-actions github-actions bot removed the stale label Jul 9, 2024
Copy link

This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days.

@darcyYe
Copy link
Contributor

darcyYe commented Jul 30, 2024

We can replace the logo before merging.

@gao-sun gao-sun merged commit e9581d8 into logto-io:master Jul 31, 2024
34 checks passed
@gao-sun gao-sun mentioned this pull request Jul 31, 2024
4 tasks
@devtekve devtekve mentioned this pull request Aug 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

7 participants