-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): postmark email connector #5886
Conversation
COMPARE TO
|
Name | Diff |
---|---|
.changeset/bright-carpets-relax.md | 📈 +67 Bytes |
packages/connectors/connector-postmark/README.md | 📈 +1.98 KB |
packages/connectors/connector-postmark/logo.svg | 📈 +2.26 KB |
packages/connectors/connector-postmark/package.json | 📈 +1.88 KB |
packages/connectors/connector-postmark/src/constant.ts | 📈 +1.34 KB |
packages/connectors/connector-postmark/src/index.test.ts | 📈 +1.18 KB |
packages/connectors/connector-postmark/src/index.ts | 📈 +1.67 KB |
packages/connectors/connector-postmark/src/mock.ts | 📈 +573 Bytes |
packages/connectors/connector-postmark/src/types.ts | 📈 +1002 Bytes |
pnpm-lock.yaml |
This solves #5885. |
@wangsijie @darcyYe can you guys take a look thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, could you add some basic test cases?
Also, it would be nice if you can make the commits signed. |
I will add some basic tests and do signed commits. |
The pnpm lockfile seems to be corrupted. Please try to resolve this issue in order to pass the CI checks. Usually this can be resolved by running |
This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sorry for this. Will be right on it after my vacation that ends in 4 days :) |
This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days. |
We can replace the logo before merging. |
Summary
Implemented a Postmark email connector that uses Postmark API rather than SMTP. This provides the ability to use templates stored in Postmark instead of the templates stored in JSON.
This is implemented by looking at
connector-sendgrid-email
and implemented it as my understanding of best practices and convensions.Testing
Have a simple uint-test that only checks configuration is valid (as also
connector-sendgrid-email
has). Else I did manual testing by connecting it in Logto UI and sending a test email trough the UI. Have also tested it in real-world scenarios by connecting it to an email provider.Checklist
.changeset