Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typo #5942

Merged
merged 1 commit into from
May 30, 2024
Merged

chore: fix typo #5942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/connectors/connector-logto-social-demo/src/constant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const defaultMetadata: ConnectorMetadata = {
logo: './logo.svg',
logoDark: null,
description: {
en: 'The demo for social sign in',
en: 'The demo for social sign-in',
},
readme: './README.md',
isStandard: true,
Expand Down
4 changes: 2 additions & 2 deletions packages/experience/src/containers/SocialSignInList/use-social.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ const useSocial = () => {
return;
}

// Invoke Native Social Sign In flow
// Invoke native social sign-in flow
if (isNativeWebview()) {
nativeSignInHandler(result.redirectTo, connector);

return;
}

// Invoke Web Social Sign In flow
// Invoke web social sign-in flow
window.location.assign(result.redirectTo);
},
[asyncInvokeSocialSignIn, handleError, nativeSignInHandler]
Expand Down
2 changes: 1 addition & 1 deletion packages/experience/src/pages/SocialSignInWebCallback/SocialSignIn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import LoadingLayer from '@/components/LoadingLayer';
import useSocialSignInListener from './use-social-sign-in-listener';

/**
* Social sign in callback page
* Social sign-in callback page
*/
type Props = {
readonly connectorId: string;
Expand Down
2 changes: 1 addition & 1 deletion packages/phrases/src/locales/en/translation/admin-console/cloud.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const cloud = {
password: 'Password',
verification_code: 'Verification code',
},
social_field: 'Social sign in',
social_field: 'Social sign-in',
finish_and_done: 'Finish and done',
preview: {
mobile_tab: 'Mobile',
Expand Down
2 changes: 1 addition & 1 deletion packages/phrases/src/locales/en/translation/admin-console/connectors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const connectors = {
page_title: 'Connectors',
title: 'Connectors',
subtitle: 'Set up connectors to enable passwordless and social sign in experience',
subtitle: 'Set up connectors to enable passwordless and social sign-in experience',
create: 'Add Social Connector',
config_sie_notice: 'You’ve set up connectors. Make sure to configure it in <a>{{link}}</a>.',
config_sie_link_text: 'sign in experience',
Expand Down
2 changes: 1 addition & 1 deletion packages/phrases/src/locales/en/translation/admin-console/sign-in-exp/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const sign_in_exp = {
no_connector_email:
'No email connector set-up yet. Before completing the configuration, users will not be able to sign in with this method. <a>{{link}}</a> in "Connectors"',
no_connector_social:
'You haven’t set up any social connector yet. Add connectors first to apply social sign in methods. <a>{{link}}</a> in “Connectors”.',
'You haven’t set up any social connector yet. Add connectors first to apply social sign-in methods. <a>{{link}}</a> in “Connectors”.',
setup_link: 'Set up',
},
save_alert: {
Expand Down
Loading