Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): google one tap #6031

Merged
merged 2 commits into from
Jun 18, 2024
Merged

feat(core): google one tap #6031

merged 2 commits into from
Jun 18, 2024

Conversation

gao-sun
Copy link
Member

@gao-sun gao-sun commented Jun 16, 2024

the Google One Tap series:

Summary

reorg sign-in experience types, validate csrf token, and allow gsi origin in security headers.

this is essential for google one tap support (tested the sign-in flow in later pulls)

Testing

unit tests added

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Jun 16, 2024

COMPARE TO master

Total Size Diff 📈 +5.8 KB

Diff by File
Name Diff
.changeset/cyan-garlics-tan.md 📈 +449 Bytes
packages/core/src/mocks/connector.ts 📈 +32 Bytes
packages/core/src/libraries/sign-in-experience/index.test.ts 📈 +1.51 KB
packages/core/src/libraries/sign-in-experience/index.ts 📈 +874 Bytes
packages/core/src/libraries/sign-in-experience/types.ts 📈 +959 Bytes
packages/core/src/libraries/social.ts 📈 +20 Bytes
packages/core/src/middleware/koa-security-headers.ts 📈 +210 Bytes
packages/core/src/routes/interaction/index.ts 📈 +3 Bytes
packages/core/src/routes/interaction/utils/social-verification.test.ts 📈 +1.15 KB
packages/core/src/routes/interaction/utils/social-verification.ts 📈 +453 Bytes
packages/core/src/routes/well-known.test.ts 📈 +181 Bytes
packages/core/src/routes/well-known.ts 📈 +61 Bytes
packages/phrases/src/locales/en/errors/session.ts 📈 +47 Bytes
packages/schemas/src/types/index.ts 📈 +41 Bytes
packages/schemas/src/types/sign-in-experience.ts 📈 +1.99 KB

@github-actions github-actions bot added size/l and removed size/m labels Jun 16, 2024
@github-actions github-actions bot added size/m and removed size/l labels Jun 16, 2024
@gao-sun gao-sun mentioned this pull request Jun 16, 2024
4 tasks
@gao-sun gao-sun requested a review from a team June 16, 2024 13:13
@github-actions github-actions bot added size/l and removed size/m labels Jun 16, 2024
@gao-sun gao-sun marked this pull request as ready for review June 16, 2024 13:40
Base automatically changed from gao-google-one-tap-connector to master June 17, 2024 04:21
@gao-sun gao-sun merged commit d9119b5 into master Jun 18, 2024
29 checks passed
@gao-sun gao-sun deleted the gao-google-one-tap-core branch June 18, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants