Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): reorg the sso connector api cleanup logic #6053

Merged
merged 1 commit into from
Jun 20, 2024
Merged

chore(test): reorg the sso connector api cleanup logic #6053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/integration-tests/src/tests/api/hook/hook.trigger.custom.data.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,12 @@
});

afterEach(async () => {
await Promise.all([webHookApi.cleanUp(), userApi.cleanUp(), organizationApi.cleanUp()]);
await Promise.all([
webHookApi.cleanUp(),
userApi.cleanUp(),
organizationApi.cleanUp(),
ssoConnectorApi.cleanUp(),
]);
});

it('create roles with scopeIds should trigger Roles.Scopes.Updated event', async () => {
Expand Down Expand Up @@ -133,7 +138,7 @@
await assertOrganizationMembershipUpdated(organization.id);
});

// TODO: Add user deletion test case

Check warning on line 141 in packages/integration-tests/src/tests/api/hook/hook.trigger.custom.data.test.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/integration-tests/src/tests/api/hook/hook.trigger.custom.data.test.ts#L141 

[no-warning-comments] Unexpected 'todo' comment: 'TODO: Add user deletion test case'.

it('should trigger `Organization.Membership.Updated` event when user is provisioned by experience', async () => {
await setEmailConnector();
Expand Down Expand Up @@ -171,8 +176,6 @@
});

await assertOrganizationMembershipUpdated(organization.id);

await ssoConnectorApi.cleanUp();
});
});
});
3 changes: 1 addition & 2 deletions packages/integration-tests/src/tests/api/interaction/organization-jit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe('organization just-in-time provisioning', () => {
const ssoConnectorApi = new SsoConnectorApi();

afterEach(async () => {
await organizationApi.cleanUp();
await Promise.all([organizationApi.cleanUp(), ssoConnectorApi.cleanUp()]);
});

beforeAll(async () => {
Expand Down Expand Up @@ -94,6 +94,5 @@ describe('organization just-in-time provisioning', () => {
);

await deleteUser(userId);
await ssoConnectorApi.cleanUp();
});
});
Loading