Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): update application organization role apis #6087

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

gao-sun
Copy link
Member

@gao-sun gao-sun commented Jun 22, 2024

Summary

  • implement POST /api/organizations/{id}/applications/roles for batch applications - organization roles assignment
  • make pagination optional for GET /api/organizations/:id/users/:userId/roles and GET /api/organizations/:id/applications/:applicationId/roles
    • rationale: we have those pages shows organization members or applications with all their roles in that organization, thus the get roles api should be ok to have no pagination

Testing

integration tests added

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Jun 22, 2024

COMPARE TO master

Total Size Diff 📈 +6.22 KB

Diff by File
Name Diff
.changeset/fresh-gorillas-obey.md 📈 +241 Bytes
packages/core/src/routes/organization-role/index.ts 📈 +2 Bytes
packages/core/src/routes/organization/application/index.openapi.json 📈 +1.22 KB
packages/core/src/routes/organization/application/index.ts 📈 +847 Bytes
packages/core/src/routes/organization/application/role-relations.ts 📈 +131 Bytes
packages/core/src/routes/organization/user/index.openapi.json 📈 +28 Bytes
packages/core/src/routes/organization/user/role-relations.ts 📈 +106 Bytes
packages/integration-tests/src/api/organization.ts 📈 +572 Bytes
packages/integration-tests/src/helpers/organization.ts 📈 +67 Bytes
packages/integration-tests/src/tests/api/hook/hook.trigger.data.test.ts 📈 +34 Bytes
packages/integration-tests/src/tests/api/interaction/consent/happy-path.test.ts 📈 +30 Bytes
packages/integration-tests/src/tests/api/organization/organization-application.test.ts 📈 +1.77 KB
packages/integration-tests/src/tests/api/organization/organization-user.test.ts 📈 +1.28 KB

@gao-sun gao-sun marked this pull request as ready for review June 22, 2024 15:58
Base automatically changed from gao-org-app-apis to master June 23, 2024 03:02
@gao-sun gao-sun merged commit 58f3eea into master Jun 23, 2024
29 checks passed
@gao-sun gao-sun deleted the gao-org-app-role-apis branch June 23, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants