Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): m2m pages in organizations #6090

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

gao-sun
Copy link
Member

@gao-sun gao-sun commented Jun 23, 2024

Summary

  1. implement m2m-related pages in the organization details page:
  • show m2m app list
  • add m2m apps
  • assign roles
  • edit roles
  1. fix typos and reuse existing components
  2. make pagination in GET /applications/:id/organizations optional to align with user APIs

Testing

API

api integration tests added

Console

image image image

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@github-actions github-actions bot added the feature Cool stuff label Jun 23, 2024
Copy link

github-actions bot commented Jun 23, 2024

COMPARE TO master

Total Size Diff ⚠️ 📈 +15.31 KB

Diff by File
Name Diff
packages/console/src/assets/icons/organization-role-feature.svg 📈 +3.07 KB
packages/console/src/assets/icons/role-feature-dark.svg 📈 +893 Bytes
packages/console/src/components/ItemPreview/ApplicationPreview.tsx 📈 +1.04 KB
packages/console/src/components/ItemPreview/UserPreview.tsx 📈 +121 Bytes
packages/console/src/components/ItemPreview/index.module.scss 📈 +29 Bytes
packages/console/src/components/OrganizationRolesSelect/index.tsx 📈 +110 Bytes
packages/console/src/hooks/use-console-routes/routes/organizations.tsx 📈 +282 Bytes
packages/console/src/pages/Applications/index.tsx 📈 +691 Bytes
packages/console/src/pages/OrganizationDetails/EditOrganizationRolesModal/index.tsx 📈 +2.99 KB
packages/console/src/pages/OrganizationDetails/MachineToMachine/AddAppsToOrganization.tsx 📈 +4.68 KB
packages/console/src/pages/OrganizationDetails/MachineToMachine/index.module.scss 📈 +202 Bytes
packages/console/src/pages/OrganizationDetails/MachineToMachine/index.tsx 📈 +5.58 KB
packages/console/src/pages/OrganizationDetails/Members/AddMembersToOrganization.tsx 📈 +38 Bytes
packages/console/src/pages/OrganizationDetails/Members/EditOrganizationRolesModal.tsx 📈 +2.57 KB
packages/console/src/pages/OrganizationDetails/Members/index.tsx 📈 +69 Bytes
packages/console/src/pages/OrganizationDetails/Settings/index.tsx 📈 +146 Bytes
packages/console/src/pages/OrganizationDetails/index.tsx 📈 +334 Bytes
packages/console/src/pages/OrganizationDetails/types.ts 📈 +43 Bytes
packages/core/src/queries/organization/application-relations.ts 📈 +55 Bytes
packages/core/src/routes/applications/application-organization.ts 📈 +106 Bytes
packages/integration-tests/src/api/application.ts 📈 +175 Bytes
packages/integration-tests/src/tests/api/application/application.organization.test.ts 📈 +296 Bytes
packages/phrases/src/locales/de/translation/admin-console/user-details.ts 📈 +101 Bytes
packages/phrases/src/locales/en/translation/admin-console/application-details.ts 📈 +83 Bytes
packages/phrases/src/locales/en/translation/admin-console/organizations.ts 📈 +49 Bytes
packages/phrases/src/locales/en/translation/admin-console/user-details.ts 📈 +90 Bytes
packages/phrases/src/locales/es/translation/admin-console/user-details.ts 📈 +94 Bytes
packages/phrases/src/locales/fr/translation/admin-console/user-details.ts 📈 +103 Bytes
packages/phrases/src/locales/it/translation/admin-console/user-details.ts 📈 +100 Bytes
packages/phrases/src/locales/ja/translation/admin-console/user-details.ts 📈 +97 Bytes
packages/phrases/src/locales/ko/translation/admin-console/user-details.ts 📈 +84 Bytes
packages/phrases/src/locales/pl-pl/translation/admin-console/user-details.ts 📈 +90 Bytes
packages/phrases/src/locales/pt-br/translation/admin-console/user-details.ts 📈 +98 Bytes
packages/phrases/src/locales/pt-pt/translation/admin-console/user-details.ts 📈 +100 Bytes
packages/phrases/src/locales/ru/translation/admin-console/user-details.ts 📈 +127 Bytes
packages/phrases/src/locales/tr-tr/translation/admin-console/user-details.ts 📈 +86 Bytes
packages/phrases/src/locales/zh-cn/translation/admin-console/user-details.ts 📈 +73 Bytes
packages/phrases/src/locales/zh-hk/translation/admin-console/user-details.ts 📈 +90 Bytes
packages/phrases/src/locales/zh-tw/translation/admin-console/user-details.ts 📈 +76 Bytes

@gao-sun gao-sun force-pushed the gao-organization-m2m-apps branch 4 times, most recently from 5ccef4c to 46fcdf2 Compare June 23, 2024 03:13
@github-actions github-actions bot added size/m and removed size/xl labels Jun 23, 2024
@github-actions github-actions bot added size/xl and removed size/m labels Jun 23, 2024
@gao-sun gao-sun marked this pull request as ready for review June 23, 2024 04:03
Base automatically changed from gao-console-m2m-organizations to master June 24, 2024 10:43
@gao-sun gao-sun merged commit 581ecd9 into master Jun 24, 2024
31 checks passed
@gao-sun gao-sun deleted the gao-organization-m2m-apps branch June 24, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants