Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor integration test ci job #6095

Merged
merged 4 commits into from
Jun 24, 2024
Merged

refactor: refactor integration test ci job #6095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c514cb
fix: remove dev feature diff check
simeng-li Jun 21, 2024
3447697
refactor: refactor alteration integration test ci job
simeng-li Jun 24, 2024
71816c9
fix: fix the dev feature disbaled integration tests
simeng-li Jun 24, 2024
0a69c0e
fix: fix alteration-compatibility-test
simeng-li Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/alteration-compatibility-integration-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ jobs:

if [ -n "$CHANGE_FILES" ]; then
echo "$CHANGE_FILES"
echo "::set-output name=has-alteration-changes::true"
echo "has-alteration-changes=true" >> $GITHUB_OUTPUT
echo "Alteration changes detected"
else
echo "::set-output name=has-alteration-changes::false"
echo "has-alteration-changes=false" >> $GITHUB_OUTPUT
echo "No alteration changes detected"
fi

Expand All @@ -50,7 +50,7 @@ jobs:
if: ${{needs.check-alteration-changes.outputs.has-alteration-changes == 'true'}}
env:
INTEGRATION_TEST: true
DEV_FEATURES_ENABLED: true
DEV_FEATURES_ENABLED: false
steps:
- uses: logto-io/actions-package-logto-artifact@v2
with:
Expand All @@ -67,7 +67,7 @@ jobs:
runs-on: ubuntu-latest
env:
INTEGRATION_TEST: true
DEV_FEATURES_ENABLED: true
DEV_FEATURES_ENABLED: false
DB_URL: postgres://postgres:postgres@localhost:5432/postgres

steps:
Expand Down
36 changes: 0 additions & 36 deletions .github/workflows/dev-feature-disabled-integration-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,44 +10,8 @@ concurrency:
cancel-in-progress: true

jobs:
detect-dev-feature-changes:
runs-on: ubuntu-latest
outputs:
has-dev-feature-changes: ${{ steps.changes-detection.outputs.has-dev-feature-changes }}

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0

# compare the current codebase with HEAD and check if there are any new lines with isDevFeaturesEnabled
- name: Get the diff and filter added lines
run: |
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
BASE=$(git merge-base origin/${{github.base_ref}} HEAD)
else
BASE=${{ github.event.before }}
fi

git diff $BASE --unified=0 | grep -E '^\+' > added_lines.txt

sed -i '/^+++ /d' added_lines.txt

- name: Check for isDevFeaturesEnabled in added lines
id: changes-detection
run: |
if grep -q 'isDevFeaturesEnabled' added_lines.txt; then
echo "Dev features enabled changes detected"
echo "::set-output name=has-dev-feature-changes::true"
else
echo "No dev features enabled changes detected"
echo "::set-output name=has-dev-feature-changes::false"
fi

package:
needs: detect-dev-feature-changes
runs-on: ubuntu-latest
if: ${{needs.detect-dev-feature-changes.outputs.has-dev-feature-changes == 'true'}}
env:
INTEGRATION_TEST: true
DEV_FEATURES_ENABLED: false
Expand Down
Loading