Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experience): avoid asking user to register when sign-up method is not supported #6460

Conversation

xiaoyijun
Copy link
Contributor

Summary

We encountered a bug as follows:

The sign-in method has email login enabled, but in the sign-up configuration, email is set to “not applicable.” When a user attempts to log in with a new email, they are prompted with a message asking if they want to create a new account. After selecting “create,” an error message appears stating “method not enabled.”

image

image

Expected behavior: After attempting to log in, the user should be informed that the email does not exist, rather than being asked if they want to create a new account (the same issue occurs with phone numbers).

Testing

image

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@xiaoyijun xiaoyijun requested a review from a team August 16, 2024 12:58
@xiaoyijun xiaoyijun self-assigned this Aug 16, 2024
Copy link

COMPARE TO master

Total Size Diff 📈 +150 Bytes

Diff by File
Name Diff
packages/experience/src/containers/VerificationCode/use-sign-in-flow-code-verification.ts 📈 +150 Bytes

@xiaoyijun
Copy link
Contributor Author

Already fixed.

@xiaoyijun xiaoyijun closed this Aug 16, 2024
@xiaoyijun
Copy link
Contributor Author

In #6406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant