Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): add http email connector #6592

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

wangsijie
Copy link
Contributor

Summary

Add new email connector to send emails by HTTP API calls.

Testing

Unit tests and local tested

截屏2024-09-18 15 34 38 截屏2024-09-18 15 34 47 截屏2024-09-18 15 35 54

Checklist

  • .changeset (will be added later)
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Sep 18, 2024

COMPARE TO master

Total Size Diff ⚠️ 📈 +15.08 KB

Diff by File
Name Diff
packages/connectors/connector-http-email/README.md 📈 +28 Bytes
packages/connectors/connector-http-email/logo-dark.svg 📈 +4.09 KB
packages/connectors/connector-http-email/logo.svg 📈 +4.09 KB
packages/connectors/connector-http-email/package.json 📈 +1.65 KB
packages/connectors/connector-http-email/src/constant.ts 📈 +818 Bytes
packages/connectors/connector-http-email/src/index.test.ts 📈 +1.16 KB
packages/connectors/connector-http-email/src/index.ts 📈 +1.79 KB
packages/connectors/connector-http-email/src/mock.ts 📈 +186 Bytes
packages/connectors/connector-http-email/src/types.ts 📈 +207 Bytes
pnpm-lock.yaml 📈 +1.09 KB

@wangsijie wangsijie force-pushed the wangsijie-log-10063-http-email-connector branch from c0d4be6 to 3336023 Compare September 18, 2024 08:02
@wangsijie wangsijie force-pushed the wangsijie-log-10063-http-email-connector branch from 3336023 to fb8b293 Compare September 18, 2024 08:06
Copy link
Contributor

@darcyYe darcyYe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, please resolve other reviewers comments

@wangsijie wangsijie force-pushed the wangsijie-log-10063-http-email-connector branch from fb8b293 to c0219c3 Compare September 19, 2024 13:32
@wangsijie wangsijie force-pushed the wangsijie-log-10063-http-email-connector branch from c0219c3 to e174e7b Compare September 23, 2024 00:57
@github-actions github-actions bot added size/l and removed size/m labels Sep 23, 2024
@wangsijie wangsijie merged commit 9adbb31 into master Sep 23, 2024
36 checks passed
@wangsijie wangsijie deleted the wangsijie-log-10063-http-email-connector branch September 23, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants