v2/package endpoint does not match specification

[tomzo]

Do you want to request a feature or report a bug?

Bug / question

What did you do?

I have started porting e2e tests from nuget.org. One of first things that fails is upload into v2/package endpoint. I am a bit confused since in 3.0 specification it says that upload should be a multipart form. But actual nuget.org tests just stream the nupkg directly to endpoint.
@loic-sharma what do think, should BaGet accept multipart/form-data or application/octet-stream at v2/package ?

Currently when client from e2e tests is uploading, on server side we get null package and 400:

public async Task Upload(IFormFile package)
        {
            if (package == null)
            {
                HttpContext.Response.StatusCode = 400;
                return;
            }

[loic-sharma]

Great find! This seems like a bug on nuget.org or documentation that should be cleaned up! My gut feeling is that we should stick to the specification. Or maybe we could fallback to reading the request's body if package is null? What do you think?

EDIT: nuget.org uses HttpRequest.Files (see this code). According to the documentation, this is populated only when the HTTP request Content-Type value is "multipart/form-data".

[tomzo]

Or maybe we could fallback to reading the request's body if package is null? What do you think?

Will do that. Same as nuget.org.

[loic-sharma]

I opened an issue on NuGet's documentation: https://github.com/NuGet/docs.microsoft.com-nuget/issues/1076

[BlythMeister]

I just started testing as found this exact issue when using paket to push to the V2 endpoint.

[tomzo]

I got this working with paket now. I haven't opened a PR yet, but if you like to cherry-pick ai-traders@1826580

That's not the only thing for paket to work though. You'll need #104 too

[BlythMeister]

I'm ok to wait for now 😀
I'm just testing out tooling, but so far I like baget. 👍

[loic-sharma]

This should be fixed by 1f1ec07 now. Could you verify @BlythMeister?

[loic-sharma]

Closing this issue as it should now be fixed. Feel free to open a new issue if you run into any other problems!