Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #7

Closed
loic-sharma opened this issue Mar 18, 2018 · 3 comments
Closed

Add tests #7

loic-sharma opened this issue Mar 18, 2018 · 3 comments

Comments

@loic-sharma
Copy link
Owner

Today, the project is as simple as possible to enable fast iteration. Tests should be added once things stabilize.

@WernerMairl
Copy link
Contributor

Hi
I like the idea of this project!
I have started to play with this Issue in my own fork....
here first step:

WernersArchive@e5ed8ca

please advice

  • if PR's are welcome
  • Rules/Guidelines to follow (my commit comment contains a few comments about my rule/guideline selection

regards
Werner

@loic-sharma
Copy link
Owner Author

loic-sharma commented Jul 2, 2018

Hello,

PRs are definitely welcome! The changes in your fork look good so far, here are my comments:

  • xUnit is perfect!
  • One xUnit csproj per implementation csproj is perfect!
  • ".Tests" suffix is perfect!
  • To stay consistent with ASP.NET/NuGet projects, the tests should be lower-cased and in the root as a sibling of the src folder
  • At NuGet, we use camel case for our test's names. For long test names, we use the ConditionHere_ExpectedResultHere format to make the tests' purpose clear. So in your fork, Create_On_Not_Existing_Folder should be named something like CreatesStoreDirectoryIfItDoesNotExist

Thank you for doing this work 😄

@loic-sharma
Copy link
Owner Author

Replacing this with #480

GotenXiao pushed a commit to GotenXiao/BaGetter that referenced this issue Jan 25, 2024
Signed-off-by: bagetter-admin <145724960+bagetter-admin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants