Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added port to config #525

Merged
merged 12 commits into from
Jun 13, 2020
Merged

Conversation

SeppPenner
Copy link
Contributor

Summary of the changes (in less than 80 chars)

  • Adds a configuration option to the BaGet server to specify the port it runs on, check appsettings.json --> Port.

Fixes #485.

src/BaGet/Program.cs Outdated Show resolved Hide resolved
@SeppPenner
Copy link
Contributor Author

The only thing to check here is that I don't know how to get the configuration in program without building the host twice:

// Todo: Don't know how to get the options without rebuilding the host!

src/BaGet/Program.cs Outdated Show resolved Hide resolved
src/BaGet/Program.cs Outdated Show resolved Hide resolved
src/BaGet/Program.cs Outdated Show resolved Hide resolved
src/BaGet/Program.cs Outdated Show resolved Hide resolved
src/BaGet/Startup.cs Outdated Show resolved Hide resolved
src/BaGet/Program.cs Outdated Show resolved Hide resolved
@loic-sharma
Copy link
Owner

This looks great! I left some nitpicks, but after that I think it's ready to merge :)

@SeppPenner
Copy link
Contributor Author

Now it looks good (and pretty clean) I would say. Sorry for the big amount of commits here but it's a lot easier to change one thing by one commit to not forget anything...

@SeppPenner
Copy link
Contributor Author

SeppPenner commented Jun 11, 2020

This probably addressed #289 as well (Can be closed, too after merge).

@loic-sharma
Copy link
Owner

Now it looks good (and pretty clean) I would say.

Yup this looks great. Thanks for the awesome contribution!

Sorry for the big amount of commits here but it's a lot easier to change one thing by one commit to not forget anything...

No worries, I squash commits when I merge changes, so feel free to do as many commits as you'd like.

@loic-sharma loic-sharma merged commit 63d7633 into loic-sharma:master Jun 13, 2020
@SeppPenner
Copy link
Contributor Author

No worries, I squash commits when I merge changes, so feel free to do as many commits as you'd like.

Haha ok :)

@SeppPenner SeppPenner deleted the add-port-to-config branch June 15, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

help me ,plz , How can i config use an other port for dotnet run
2 participants