-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added port to config #525
Added port to config #525
Conversation
The only thing to check here is that I don't know how to get the configuration in program without building the host twice: Line 43 in 167fc22
|
This looks great! I left some nitpicks, but after that I think it's ready to merge :) |
Now it looks good (and pretty clean) I would say. Sorry for the big amount of commits here but it's a lot easier to change one thing by one commit to not forget anything... |
This probably addressed #289 as well (Can be closed, too after merge). |
Yup this looks great. Thanks for the awesome contribution!
No worries, I squash commits when I merge changes, so feel free to do as many commits as you'd like. |
Haha ok :) |
Summary of the changes (in less than 80 chars)
appsettings.json
-->Port
.Fixes #485.