-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for version autocomplete #576
Support for version autocomplete #576
Conversation
This looks great, thanks for doing this!
Yup this looks like the right direction. I left a few minor nitpicks, my only real feedback is that we shouldn't reuse the Please let me know if you have any questions with the Azure Search implementation! This may be a good opportunity for me to beef up our developer docs 😊 |
By the way, I think it'd be fine for this pull request to support just the database. We can add Azure Search support later in a separate pull request. |
Good idea, I've made a few more little changes and it passes the tests so if we get this in I can revisit for the Azure stuff, after we've written some integration tests for it. |
…/davidackroyd99/BaGet into feature/da/autocomplete-versions
Thanks for your contribution! |
Does not allow version search support for Azure yet - I have no way of testing this, when this PR is approved as being in roughly the right direction I'll try and set up a test env.
Addresses #291