-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to .NET 6 #717
base: main
Are you sure you want to change the base?
Upgrade to .NET 6 #717
Conversation
Succeeded testing with |
Succeeded testing with |
Failed testing with |
OK, I'm stuck a little. But seems like
Cause now migrations (existing one) generates next script CREATE TABLE `Packages` (
`Key` int NOT NULL AUTO_INCREMENT,
`Id` varchar(128) NOT NULL,
`Authors` varchar(4000) NULL,
`Description` varchar(4000) NULL,
`Downloads` bigint NOT NULL,
`HasReadme` tinyint(1) NOT NULL,
`Language` varchar(20) NULL,
`Listed` tinyint(1) NOT NULL,
`MinClientVersion` varchar(44) NULL,
`Published` datetime(6) NOT NULL,
`RequireLicenseAcceptance` tinyint(1) NOT NULL,
`Summary` varchar(4000) NULL,
`Title` varchar(256) NULL,
`IconUrl` varchar(4000) NULL,
`LicenseUrl` varchar(4000) NULL,
`ProjectUrl` varchar(4000) NULL,
`RepositoryUrl` varchar(4000) NULL,
`RepositoryType` varchar(100) NULL,
`Tags` varchar(4000) NULL,
`RowVersion` datetime(6) NULL DEFAULT CURRENT_TIMESTAMP(6) ON UPDATE CURRENT_TIMESTAMP(6),
`Version` varchar(64) NOT NULL,
CONSTRAINT `PK_Packages` PRIMARY KEY (`Key`)
); Instead of using If someone has an ideas - I would appreciate it UPD. Has asked in PomeloFoundation/Pomelo.EntityFrameworkCore.MySql#1606 |
Succeeded testing with
|
@loic-sharma seems like I finished planned jobs. Could you please:
|
This is a great PR. I hope the maintainer will be able to review and include it. |
agree, great PR, already using it ^_^ |
@loic-sharma any chance this PR will see the world? |
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="$(MicrosoftEntityFrameworkCorePackageVersion)"> | ||
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
<PrivateAssets>all</PrivateAssets> | ||
</PackageReference> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason behind this change for Microsoft.EntityFrameworkCore.Design
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is to define it as design-time dependency for concrete project and does not include it's dll as a part of artifacts or as a part of implicit dependency to other projects
(https://docs.microsoft.com/en-us/ef/core/cli/services#referencing-microsoftentityframeworkcoredesign)
@loic-sharma should we separate DB provider-related package versions from the variable For now there is a possibility to upgrade next deps:
|
@loic-sharma friendly ping |
Let's merge, dudes?) |
before .net7 is out would be awesome |
@loic-sharma that's a friendly reminder from me again. Could we merge it? |
I don't usually like to write comments with no real purpose or structure; but I do personally support the PR and would be in favour of having it merged. |
Maybe @loic-sharma should add more maintainers to this project, might be too busy with other things |
Is there any progress on this PR? |
Seems like author has no more time for supporting this project. And no other maintainers |
Would someone besides me be interested in creating a maintained fork? |
The most active fork appears to be @pieroviano's. See https://github.com/pieroviano/BaGet or #754 |
Hi @loic-sharma,
Thank you for awesome project (hope it is alive). Wanna contribute and make some new feature extensions, but first of all, the code base of BaGet should be updated to the new stack. So I have decided to start from update PR.
This closes #707 and #618 (as outdated). Also it helps us to use the latest features/libraries and performance of .NET 6
Next work should be done:
Test:
Also need to pay attention to:
Pomelo.EntityFrameworkCore.MySql v6.0.0
has breaking changes, now MySql version should be specified. Now the feature of version autodetection was used inBaGet.Database.MySql
(extracted to Use not outdated libraries in BaGet.Azure #720)BaGet.Azure
uses very outdated librariesMicrosoft.Azure.Search
&Microsoft.Azure.Storage.Blob
. Last releaseAzure.Search.Documents
&Azure.Storage.Blobs
should be used and project should be rewritten to their API (I think we will extract it to the new issue, but I need to document this founding here)I will continue to test/adjust the project, but help would be appreciated. I think when majority of items would be done, it would be cool to release a new alpha version for mass testing