-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors on Debian #1
Comments
Hi @ebourg and thanks for the report. I managed to reproduce the issue and I'll be looking into it. I'll keep you posted here. But apart from the problem you found, I'm happy to hear about the integration into debian. I would be happy to discuss with you about the best way to integrate findjava in the distribution. The idea is to give maximum control to maintainers about which JVMs are available for software packaged by the distribution itself. |
@ebourg , I created PR #2 which should fix the issue if my assumptions are correct. What I assumed, is that you built the software from the instructions in the README.md instead of relying on my very basic and probably broken in many ways ubuntu/debian packaging located in So let me know if the PR fixes your issue and if yes, I'll merge it. |
I may have messed with the paths actually. The binary is in Here is the layout of the binary package:
I guess I just have to patch the value of |
My apologies for the late response, I somehow missed the GitHub notification of your response. I would prefer if you do not have to patch the source code. I'll check what are the options to provide a configurable build in the form of an environment variable you could pass when calling make. When I tried to package it myself, I defined the following
Do I assume correctly that you defined your own debian/rules file and that you called make in it? |
Yes that's correct. lintian complained about the arch dependent binary in The
and
|
I pushed some additional changes to branch You should be able to build using Let me know if that works and if the solution suits you. |
@ebourg I was not fully happy with the necessity to require a file for configuring variables. So I worked a bit more on it and pushed new changes to #2 so that you can also override things when building and even combine both approaches. You now have a few build options: Option 1Use the pre-configured GO_TAGS="-tags debian" make Option 2Use the pre-configured GO_TAGS="-tags standalone_linux" GO_LD_FLAGS="-X 'findjava/linker.MetadataExtractorDir=/usr/share/findjava/metadata-extractor'" make Option 3Override all the variables manually: GO_LD_FLAGS="-X 'findjava/linker.ConfigDir=/etc/findjava/' -X 'findjava/linker.CacheDir=~/.cache/findjava/' -X 'findjava/linker.MetadataExtractorDir=/usr/share/findjava/metadata-extractor'" make Checking the resulting binaryYou can check the resulting binary with command:
More details can be found in the README.md of #2 |
Fix invalid metadata extractor path for local build #1
Hi,
I'm trying to package findjava for Debian, it builds fine but I'm getting errors at runtime:
without arguments:
and with arguments:
The JVM path displayed in the error message changes on each invocation and seems randomly picked from
/usr/lib/jvm/
.Here is the content of my
/usr/lib/jvm/
directory:The text was updated successfully, but these errors were encountered: