-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add next-intl
framework
#934
Conversation
`{t('${keypath}')}`, | ||
`t('${lastSegment}')`, | ||
`t('${keypath}')`, | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to consider an existing namespace in this function, to automatically remove the namespace from the suggestion?
Also if the component uses a given namespace, it would be great if that would show up as a default when entering a key. Is this possible?
If not, I guess this is good enough!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Namespaces were hard to implement with the current architecture. Let's get the framework running as is now
@terales I noticed there was a release of |
Any progress with this? |
I also am really interested in this framework, would be great to have a quick review ;) |
# Conflicts: # src/frameworks/index.ts
@terales I've just rebased this PR on the latest changes from |
Sounds great!
It would be released with the closest release
…On Wed, 2 Aug 2023 at 03:51 Jan Amann ***@***.***> wrote:
@terales <https://github.com/terales> I've just rebased this PR on the
latest changes from main. Any chance this could get released?
—
Reply to this email directly, view it on GitHub
<#934 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOU474HTO4WUX2E7A7QE2LXTH2IDANCNFSM6AAAAAAYKGDKR4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi , thanks for the great work ! |
What is the update cycle to this? This is really needed. |
@visualcookie You can check out this branch and run a dev build of the extension: https://github.com/lokalise/i18n-ally/wiki/Contribute#extension-development |
`{t('${keypath}')}`, | ||
`t('${lastSegment}')`, | ||
`t('${keypath}')`, | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Namespaces were hard to implement with the current architecture. Let's get the framework running as is now
* WIP * Load framework * Add VSCode setting * Basic PoC * Cleanup * Add preferred keystyle * Clean up * All permutations for keypaths
Closes #820
My.Movie.mp4