Skip to content

Fix logLevel not being applied in development environments #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drdaemos wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix logLevel not being applied in development environments #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dfdfa4
Fix logLevel not affection development environments
drdaemos Sep 26, 2025
b77da38
Fix lint
drdaemos Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 1 addition & 29 deletions src/logging/loggerConfigResolver.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { resolveLogger, resolveLoggerConfiguration } from './loggerConfigResolve

describe('loggerConfigResolver', () => {
describe('resolveLoggerConfiguration', () => {
it('resolves prod configuration', () => {
it('resolves configuration', () => {
const loggerConfig = resolveLoggerConfiguration({
logLevel: 'warn',
nodeEnv: 'production',
Expand All @@ -23,34 +23,6 @@ describe('loggerConfigResolver', () => {
`)
})

it('resolves dev configuration', () => {
const loggerConfig = resolveLoggerConfiguration({
logLevel: 'debug',
nodeEnv: 'development',
})

expect(loggerConfig).toMatchObject({
levels: {
labels: {
'10': 'trace',
'20': 'debug',
'30': 'info',
'40': 'warn',
'50': 'error',
'60': 'fatal',
},
values: {
debug: 20,
error: 50,
fatal: 60,
info: 30,
trace: 10,
warn: 40,
},
},
})
})

it('does not crash during label resolution', () => {
const loggerConfig = resolveLoggerConfiguration({
logLevel: 'warn',
Expand Down
24 changes: 9 additions & 15 deletions src/logging/loggerConfigResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,15 @@ export function resolveMonorepoLogger(appConfig: MonorepoAppLoggerConfig): Logge
return resolveLogger(appConfig)
}

const configuration = resolveMonorepoLoggerConfiguration(appConfig) as LoggerOptions
const configuration = resolveMonorepoLoggerConfiguration(appConfig)
return pino(configuration)
}

// Note that transports do not work in vitest, likely because pino attempts to run them in a separate worker
/* c8 ignore next 25 */
export function resolveMonorepoLoggerConfiguration(
appConfig: MonorepoAppLoggerConfig,
): LoggerOptions | Logger {
if (appConfig.nodeEnv !== 'development') {
return resolveLoggerConfiguration(appConfig)
}

): LoggerOptions {
return {
level: appConfig.logLevel,
formatters: {
Expand All @@ -49,21 +45,15 @@ export function resolveMonorepoLoggerConfiguration(
append: appConfig.append ?? false,
},
},
}
} satisfies LoggerOptions
}

export function resolveLogger(appConfig: AppLoggerConfig): Logger {
if (appConfig.nodeEnv !== 'production') {
return resolveLoggerConfiguration(appConfig) as Logger
}
const configuration = resolveLoggerConfiguration(appConfig)

const configuration = resolveLoggerConfiguration(appConfig) as LoggerOptions
return pino(configuration)
}

export function resolveLoggerConfiguration(appConfig: AppLoggerConfig): LoggerOptions | Logger {
if (appConfig.nodeEnv !== 'production') {
return pino(
configuration,
pretty({
sync: true,
minimumLevel: appConfig.logLevel as Level,
Expand All @@ -74,6 +64,10 @@ export function resolveLoggerConfiguration(appConfig: AppLoggerConfig): LoggerOp
)
}

return pino(configuration)
}

export function resolveLoggerConfiguration(appConfig: AppLoggerConfig): LoggerOptions {
return {
level: appConfig.logLevel,
formatters: {
Expand Down
Loading