Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add shopify websockets room #163

Merged
merged 1 commit into from
Jun 6, 2024
Merged

feat: add shopify websockets room #163

merged 1 commit into from
Jun 6, 2024

Conversation

arthuracs
Copy link
Contributor

@arthuracs arthuracs commented Jun 6, 2024 •
edited by jira bot
Loading

Changes

AP-3831

Adds a shopify websockets room using a new INTEGRATION_ID_SCHEMA

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

@arthuracs arthuracs added the minor label Jun 6, 2024
@arthuracs arthuracs requested review from jmontoyaa and removed request for a team June 6, 2024 14:28
jmontoyaa
jmontoyaa approved these changes Jun 6, 2024
View reviewed changes
Copy link

@jmontoyaa jmontoyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arthuracs arthuracs merged commit 7a69614 into main Jun 6, 2024
5 checks passed
@arthuracs arthuracs deleted the AP-3831_shopify-websockets-room branch June 6, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmontoyaa jmontoyaa jmontoyaa approved these changes

@Drodevbar Drodevbar Drodevbar approved these changes

@kibertoad kibertoad Awaiting requested review from kibertoad kibertoad is a code owner

@CarlosGamero CarlosGamero Awaiting requested review from CarlosGamero CarlosGamero is a code owner

@dariacm dariacm Awaiting requested review from dariacm dariacm is a code owner

@ondrejsevcik ondrejsevcik Awaiting requested review from ondrejsevcik

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthuracs @jmontoyaa @Drodevbar