Use separate checks for separate healthchecks #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
requested review from
CarlosGamero,
dariacm,
ondrejsevcik and
a team
as code owners
CarlosGamero
reviewed
Aug 1, 2024
| @@ -8,7 +8,7 @@ export type HealthcheckEntry = { | |||
| } | |||
|
|
|||
| export type HealthcheckResultsStoreParams = { | |||
| healthcheckNumber: number // how many healthchecks does the system have | |||
| healthcheckNumber: number // maximum amount of healthchecks that the system can have | |||
There was a problem hiding this comment.
would make sense to change it to maxHealthcheckNumber or maxHealthcheckSupported, but it would be a breaking change, maybe we can make a note to do it on next major release
There was a problem hiding this comment.
it wasn't used yet, so maybe we can sneak that one under the radar :D
CarlosGamero
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously it will only register Gauges for the very first healthcheck.
Checklist
major,minor,patchorskip-release