Add AbstractPeriodicJob to the bg job lib

[kibertoad]

Changes

Make the AbstractPeriodicJob reusable across libraries

Checklist

• Apply one of following labels; major, minor, patch or skip-release
• I've updated the documentation, or no changes were necessary
• I've updated the tests, or no changes were necessary

[CarlosGamero]

Shouldn't we always log start and finish?

[kibertoad]

since this job is happening on a regular cadence, log might not always be useful, so there is a way to remove the noise

[CarlosGamero]

I see and it makes sense, but if I am not wrong it is false by default, I would expect to have it true but no strong opinion from my side

[CarlosGamero]

On AbstractBackgroundJobProcessor we use these names but in the other direction, should we follow the same approach? (process for the abstract method and processInternal for the private one)

[kibertoad]

not sure. note that there needs to be a public entry point that toad-scheduler task can invoke. would you call that processInternal?

[CarlosGamero]

Oh I see, sorry for the misunderstanding, wondering if we can make the method private and createTask receive the method to call, something like:

createTask(logger: CommonLogger, jobId: string, method: (execId: string) => Promise<void>): AsyncTask

But I see createTask is exposed, so maybe it is not a good idea 🤔

[kibertoad]

yeah, I would probably keep it as-is, not sure that tinkering with this part would decrease complexity significantly

[CarlosGamero]

Yeah, I am fine with it, my only point was not allowing to directly call that method or override it