Adding isNonEmptyArray #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosGamero
requested review from
kibertoad,
dariacm,
ondrejsevcik and
a team
as code owners
Dosexe
approved these changes
Aug 28, 2024
kibertoad
reviewed
Aug 28, 2024
| * @param {readonly T[]} array - The array to be checked, which should be read-only. | ||
| * @returns {array is [T, ...T[]]} - Returns true if the array is non-empty, false otherwise. | ||
| */ | ||
| export const isNonEmptyArray = <T>(array: readonly T[]): array is [T, ...T[]] => array.length > 0 |
There was a problem hiding this comment.
is it correct to transform readonly array into non-readonly array here?
There was a problem hiding this comment.
Mmm, good point! also, readonly does not make too much sense for this method (we are just checking length) removing it
kibertoad
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding
isNonEmptyArraymethod to facilitate working withnonemptyconstraint from ZodChecklist
major,minor,patchorskip-release