Universal ts lib moving last array utils method from node core #331
Conversation
| export async function callChunked<Item>( | ||
| chunkSize: number, | ||
| array: readonly Item[], | ||
| processFn: (arrayChunk: Item[]) => Promise<unknown>, | ||
| ): Promise<void> { |
There was a problem hiding this comment.
With this one, all array utils from node-core are already here, so we plan removing them from there
| * @deprecated Use `areArraysEqual` instead. | ||
| * |
There was a problem hiding this comment.
I thought that we can have something more common, and not only for string arrays
| /** | ||
| * Check if two arrays are equal. | ||
| * The arrays are considered equal if they have the same length, same order and the elements at each index by value are equal. | ||
| * Note: Equality is compared by value and not by reference. | ||
| */ | ||
| export function areArraysEqual(a: unknown[], b: unknown[]): boolean { |
There was a problem hiding this comment.
Thinking about having areEquals so it can be also used to compare objects, still thinking about it
There was a problem hiding this comment.
from perf perspective separate functions are better, because isomorphic params (different structure across multiple calls) will cause v8 to deoptimize.
There was a problem hiding this comment.
I am not sure, my idea was to have something like:
areEquals(a: unknown, b: unknown): boolean
it won't use isomorphic params but not sure if v8 will deoptimize it
There was a problem hiding this comment.
As an example -> db19fb8
|
Will open a new PR with final version |
CarlosGamero
deleted the
feature/universal_ts_lib_moving_array_utils_from_node-core
branch
Changes
Please describe
Checklist
major,minor,patchorskip-release