Migrate to undici 7 #401
Merged
Migrate to undici 7 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
requested review from
CarlosGamero,
dariacm,
ondrejsevcik and
a team
as code owners
kibertoad
commented
Dec 5, 2024
| @@ -93,7 +93,7 @@ export async function sendDelete< | |||
| reset: options.disableKeepAlive ?? false, | |||
| bodyTimeout: Object.hasOwn(options, 'timeout') ? options.timeout : DEFAULT_OPTIONS.timeout, | |||
| headersTimeout: Object.hasOwn(options, 'timeout') ? options.timeout : DEFAULT_OPTIONS.timeout, | |||
| throwOnError: false, | |||
| throwOnError: undefined, | |||
There was a problem hiding this comment.
undici no longer supports this as a parameter and expects https://undici.nodejs.org/#/docs/api/Dispatcher?id=responseerror to be used instead.
Since we always consumed this parameter directly instead of relying on undici handling (in order to provide sufficient amount of error details), we just ensure that we no longer pass-through this parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This uses newer version of undici-retry that depends on undici v7
Checklist
major,minor,patchorskip-release