Skip to content

Commit

Permalink
build: remove Python pip --no-user option (nodejs#47338)
Browse files Browse the repository at this point in the history
Python pip no longer has a --no-user option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
  • Loading branch information
cclauss authored Apr 2, 2023
1 parent 85705a4 commit d8e3fca
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1493,8 +1493,8 @@ cpplint: lint-cpp
# Try with '--system' if it fails without; the system may have set '--user'
lint-py-build:
$(info Pip installing flake8 linter on $(shell $(PYTHON) --version)...)
$(PYTHON) -m pip install --no-user --upgrade -t tools/pip/site-packages flake8 || \
$(PYTHON) -m pip install --no-user --upgrade --system -t tools/pip/site-packages flake8
$(PYTHON) -m pip install --upgrade -t tools/pip/site-packages flake8 || \
$(PYTHON) -m pip install --upgrade --system -t tools/pip/site-packages flake8

.PHONY: lint-py
ifneq ("","$(wildcard tools/pip/site-packages/flake8)")
Expand All @@ -1513,8 +1513,8 @@ endif
# Try with '--system' if it fails without; the system may have set '--user'
lint-yaml-build:
$(info Pip installing yamllint on $(shell $(PYTHON) --version)...)
$(PYTHON) -m pip install --no-user --upgrade -t tools/pip/site-packages yamllint || \
$(PYTHON) -m pip install --no-user --upgrade --system -t tools/pip/site-packages yamllint
$(PYTHON) -m pip install --upgrade -t tools/pip/site-packages yamllint || \
$(PYTHON) -m pip install --upgrade --system -t tools/pip/site-packages yamllint

.PHONY: lint-yaml
# Lints the YAML files with yamllint.
Expand Down

0 comments on commit d8e3fca

Please sign in to comment.