Skip to content

Commit

Permalink
feat: Feast Operator support log level configuration for services (fe…
Browse files Browse the repository at this point in the history 
…ast-dev#4808)

* fix: Feast Operator  updated the kustomize version to v5.5.0

Signed-off-by: Abdul Hameed <ahameed@redhat.com>

* feat : Feast Operator support log level configuration for services

Signed-off-by: Abdul Hameed <ahameed@redhat.com>

* Update infra/feast-operator/internal/controller/services/services.go

Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>

* Update infra/feast-operator/internal/controller/services/services.go

Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>

* added unit test for loglevel

Signed-off-by: Abdul Hameed <ahameed@redhat.com>

* fix the loglevel command

Signed-off-by: Abdul Hameed <ahameed@redhat.com>

* moved the logLevel under LocalRegistryConfig and updated testcase to validate it

Signed-off-by: Abdul Hameed <ahameed@redhat.com>

---------

Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com>
  • Loading branch information
@redhatHameed @tchughesiv
redhatHameed and tchughesiv authored Dec 5, 2024
1 parent 3649554 commit 19424bc
Show file tree
Hide file tree
Showing 7 changed files with 460 additions and 9 deletions.
12 changes: 12 additions & 0 deletions infra/feast-operator/api/v1alpha1/featurestore_types.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ type OfflineStore struct {
ServiceConfigs `json:",inline"`
Persistence *OfflineStorePersistence `json:"persistence,omitempty"`
TLS *OfflineTlsConfigs `json:"tls,omitempty"`
// LogLevel sets the logging level for the offline store service
// Allowed values: "debug", "info", "warning", "error", "critical".
// +kubebuilder:validation:Enum=debug;info;warning;error;critical
LogLevel string `json:"logLevel,omitempty"`
}

// OfflineTlsConfigs configures server TLS for the offline feast service. in an openshift cluster, this is configured by default using service serving certificates.
Expand Down Expand Up @@ -130,6 +134,10 @@ type OnlineStore struct {
ServiceConfigs `json:",inline"`
Persistence *OnlineStorePersistence `json:"persistence,omitempty"`
TLS *TlsConfigs `json:"tls,omitempty"`
// LogLevel sets the logging level for the online store service
// Allowed values: "debug", "info", "warning", "error", "critical".
// +kubebuilder:validation:Enum=debug;info;warning;error;critical
LogLevel string `json:"logLevel,omitempty"`
}

// OnlineStorePersistence configures the persistence settings for the online store service
Expand Down Expand Up @@ -177,6 +185,10 @@ type LocalRegistryConfig struct {
ServiceConfigs `json:",inline"`
Persistence *RegistryPersistence `json:"persistence,omitempty"`
TLS *TlsConfigs `json:"tls,omitempty"`
// LogLevel sets the logging level for the registry service
// Allowed values: "debug", "info", "warning", "error", "critical".
// +kubebuilder:validation:Enum=debug;info;warning;error;critical
LogLevel string `json:"logLevel,omitempty"`
}

// RegistryPersistence configures the persistence settings for the registry service
Expand Down
66 changes: 66 additions & 0 deletions infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,17 @@ spec:
description: PullPolicy describes a policy for if/when to
pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the offline store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OfflineStorePersistence configures the persistence
settings for the offline store service
Expand Down Expand Up @@ -576,6 +587,17 @@ spec:
description: PullPolicy describes a policy for if/when to
pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the online store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OnlineStorePersistence configures the persistence
settings for the online store service
Expand Down Expand Up @@ -939,6 +961,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the registry service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: RegistryPersistence configures the persistence
settings for the registry service
Expand Down Expand Up @@ -1429,6 +1462,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the offline store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OfflineStorePersistence configures the persistence
settings for the offline store service
Expand Down Expand Up @@ -1784,6 +1828,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the online store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OnlineStorePersistence configures the persistence
settings for the online store service
Expand Down Expand Up @@ -2155,6 +2210,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the registry service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: RegistryPersistence configures the persistence
settings for the registry service
Expand Down
15 changes: 15 additions & 0 deletions infra/feast-operator/config/samples/v1alpha1_featurestore_services_loglevel.yaml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
apiVersion: feast.dev/v1alpha1
kind: FeatureStore
metadata:
name: sample-services-loglevel
spec:
feastProject: my_project
services:
onlineStore:
logLevel: debug
offlineStore:
logLevel: debug
registry:
local:
logLevel: info

68 changes: 67 additions & 1 deletion infra/feast-operator/dist/install.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,17 @@ spec:
description: PullPolicy describes a policy for if/when to
pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the offline store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OfflineStorePersistence configures the persistence
settings for the offline store service
Expand Down Expand Up @@ -584,6 +595,17 @@ spec:
description: PullPolicy describes a policy for if/when to
pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the online store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OnlineStorePersistence configures the persistence
settings for the online store service
Expand Down Expand Up @@ -947,6 +969,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the registry service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: RegistryPersistence configures the persistence
settings for the registry service
Expand Down Expand Up @@ -1437,6 +1470,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the offline store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OfflineStorePersistence configures the persistence
settings for the offline store service
Expand Down Expand Up @@ -1792,6 +1836,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the online store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OnlineStorePersistence configures the persistence
settings for the online store service
Expand Down Expand Up @@ -2163,6 +2218,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the registry service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: RegistryPersistence configures the persistence
settings for the registry service
Expand Down Expand Up @@ -2894,7 +2960,7 @@ spec:
- --leader-elect
command:
- /manager
image: feastdev/feast-operator:0.41.0
image: feastdev/feast-operator:0.42.0
livenessProbe:
httpGet:
path: /healthz
Expand Down
Loading

0 comments on commit 19424bc

Please sign in to comment.