Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Missing kwargs option in SAD.load_from_file #24

Merged
merged 5 commits into from
Mar 10, 2021
Merged

Bugfix: Missing kwargs option in SAD.load_from_file #24

merged 5 commits into from
Mar 10, 2021

Conversation

lokijuhy
Copy link
Owner

Thought I'd give the datatc PR for the this bugfix to you since it's a small one, in case you're interested 🤷‍♀️

@lokijuhy lokijuhy requested a review from mcmahom5 March 10, 2021 13:08
mcmahom5
mcmahom5 approved these changes Mar 10, 2021
View reviewed changes
Copy link

@mcmahom5 mcmahom5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it here, and it works well.

@lokijuhy lokijuhy merged commit d3c4c48 into master Mar 10, 2021
@lokijuhy lokijuhy deleted the bugfix_kwargs_SAD_load_file branch March 10, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmahom5 mcmahom5 mcmahom5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lokijuhy @mcmahom5