Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show overlay when it's a new translation #84

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: show overlay when it's a new translation #84

merged 1 commit into from
Jul 11, 2024

Conversation

samulopez
Copy link
Contributor

@samulopez samulopez commented Jul 11, 2024 •
edited
Loading

it fixes: #83

@samulopez samulopez force-pushed the fix/show-overlay-when-its-a-new-translation branch from b9cea89 to d321eb3 Compare July 11, 2024 09:05
@samulopez samulopez force-pushed the fix/show-overlay-when-its-a-new-translation branch from d321eb3 to b1cdebd Compare July 11, 2024 09:25
lokinmodar
lokinmodar approved these changes Jul 11, 2024
View reviewed changes
Copy link
Owner

@lokinmodar lokinmodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mergin these but will wait for the Battle Talk fix before submitting the plugin to avoid flooding the Dalamud server and our Issues to be flooded with crash reports <3

@lokinmodar lokinmodar merged commit 194c008 into lokinmodar:APIX Jul 11, 2024
1 of 2 checks passed
@samulopez samulopez deleted the fix/show-overlay-when-its-a-new-translation branch July 11, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokinmodar lokinmodar lokinmodar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation only shows up when you run the same dialogue again
2 participants
@samulopez @lokinmodar