Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics: Weapon color reverting to default after Covert Op #420

Open
Maebalzurakin opened this issue Aug 19, 2019 · 3 comments
Open

Graphics: Weapon color reverting to default after Covert Op #420

Maebalzurakin opened this issue Aug 19, 2019 · 3 comments
Labels
bug Something isn't working highlander Requires a change to the community highlander

Comments

@Maebalzurakin
Copy link

Maebalzurakin commented Aug 19, 2019

As of Beta 6, sending someone on a Covert Op is causing their weapon to revert to the base color. I attached a screenshot. You can see the weapon color is still set to black in the selector, but shows as the default tan on the character model.

Not game breaking, but strange and annoying.

I did add a mod, called 'longer names v2', I will disable and see if it might be the cause.

My reason for wanting longer names, is also a feature request. I really want to be able to see a soldiers squad name in the soldier list. To obtain this, I change their first name to be first and last, then their last name becomes their squad name or role. This has the benefit that clicking on the name header in the soldier list will sort by last name, which is now their squad or role.

However, a lot of the soldiers with long names did not have the space for both names in the first cell... so the mod is added.

Ideally, you could add a column in the soldier list for squad name.

weapon color
squad list

@Maebalzurakin
Copy link
Author

Maebalzurakin commented Aug 19, 2019

I have disabled the long names mod and the color change is still happening on new covert missions. It has to be something related to beta 6. I did see that there were some new lines added to the files related to SMG weapons. Perhaps that is what is causing this?

Armor colors are not affected. Weapon colors are only affected on covet missions and not regular missions.... at least the missions I have seen so far.

In the attached pic, it is an SMG that changed color, but it will happen with other weapons types too.

@robojumper
Copy link
Contributor

Weapon color and pattern ultimately come, despite being settings on the character customization screen in addition to the weapon one, only from the state of the weapon. Equipping an otherwise unmodified weapon copies this customization from the character to the weapon. However, weapons with a different color or pattern are not considered modified, so any code that un-equips the weapon back to HQ (like the code that runs on sending soldiers to covert actions without associated ambush risks) will erase this weapon from existence because it'll stack with the other unmodified weapons -- and the re-equip code will grab a new, unmodified weapon without re-coloring it. The copy of weapon customization from character to weapon only happens in specific situations, such as actively equipping a weapon using the UI or giving a unit its initial loadout upon creation/promotion.

Here's a thing to test: Can you rename the weapon, then repeat your experiment? Renamed weapons are considered modified and should correctly re-appear when the soldier is done with the covert action. Note that I believe this issue only affects covert actions without an ambush risk.

@Maebalzurakin
Copy link
Author

Test done. The renamed weapon did not change color.

Thank you for letting me know how to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working highlander Requires a change to the community highlander
Projects
None yet
Development

No branches or pull requests

3 participants