Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCGS_Unit:EquipOldItems does not apply color and pattern to unmodified items #609

Closed
robojumper opened this issue Aug 20, 2019 · 4 comments · Fixed by #1285
Closed

XCGS_Unit:EquipOldItems does not apply color and pattern to unmodified items #609

robojumper opened this issue Aug 20, 2019 · 4 comments · Fixed by #1285

Comments

@robojumper
Copy link
Member

See long-war-2/lwotc#420

Sending a soldier to a covert action without ambush risks unequips a colored weapon, stacks it with the existing stack in HQ. Re-equipping decides that a new copy needs to be made from the infinite stack, but doesn't apply customization to it.

@MrNiceUK
Copy link
Contributor

With both the unit and the weapon themselves having weapon customizations stored, I saw some of the messiness with the logic for keeping them in sync (or not!) when addressing Gremlin customizations, but at that point didn't want to touch it! Possibly means the gremlin may be inconsistent about whether it's using the weapon stored customization colours or the units (if they are different) too...

@Iridar Iridar added this to the 1.27.0 milestone Aug 11, 2023
@Iridar
Copy link
Contributor

Iridar commented Oct 29, 2023

Note that at the end of EquipOldItems there's ApplyBestGearLoadout() which does apply weapon customization from soldier appearance.

@Iridar
Copy link
Contributor

Iridar commented Oct 29, 2023

This could be fixed in EquipOldItems(), but it could also be fixed for good in AddItemToInventory(), where it arguably should have been all this time. What's the point of even storing weapon customization on Unit State if you're not gonna apply it to all weapons you equip?

@Iridar
Copy link
Contributor

Iridar commented Oct 29, 2023

With one exception of modified items, e.g. nicknamed/upgraded.

Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Oct 29, 2023
@Iridar Iridar removed this from the 1.27.0 milestone Oct 29, 2023
Iridar pushed a commit that referenced this issue Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants