Fix Pool dangling connections
#109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
August 20, 2024 12:35
…ng pool.acquire() invocations
|
@long2ice , I need thorough reviews on this PR, it is about changes in architecture, could you ping/tag other maintainers? @DFilyushin, please review this PR as well (also keeping on the discussion #108 ). |
added 9 commits
August 22, 2024 09:38
DFilyushin
approved these changes
Aug 22, 2024
|
@DFilyushin , many thanks for approval. |
|
OK. will see. |
DaniilAnichin
approved these changes
Aug 25, 2024
…valuation and optimisation details
|
Thanks! |
|
Not working for me: 2024-08-26 12:16:35 asynch.pool WARNING | Connection lost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MRs #106 and #107 were only foresteps to the real problem: poor connection management via the
Poolclass. My colleagues found that the version 0.2.4 leaves unclosed/dangling connections to the ClickHouse. Rolling back to the previous v0.2.3 made this problem disappear. Moreover, there is the discussion #108 highlighting the same problem.This PR #109 addresses the dangling connection issue by injecting into the
Poolclass the interface for asynchronous context manager support. When entering a pool context, theminsizeconnections are established. Within the pool context one can acquire up to themaxsizeconnections, but not more orPoolErrorwill be raised. Before leaving the pool context, all connections get closed.Many thanks to the psycopg_pool open-source implementation and this article on psycopg3 pool design.
UPD
Sorry for overloading the PR with changes on
Connectionclass, including tests onasynch.proto.Connectionclass and some minor grooming or refactoring. That is the result of API alignment in my opinion + bringing more order and unification in the API.