Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails on 3.10 - invalid argument loop #15

Closed
pds2208 opened this issue Oct 5, 2021 · 1 comment
Closed

Fails on 3.10 - invalid argument loop #15

pds2208 opened this issue Oct 5, 2021 · 1 comment

Comments

@pds2208
Copy link

pds2208 commented Oct 5, 2021

Python 3.10 has removed the use of the loop argument in async io.

The issue is in line 512 and 522 in connection.pyx where it passes in the loop loop=loop. Running on 3.10 and later can be determined by:

use_loop = True if sys.version_info < (3, 10) else False

and this can be used to decide whether to pass in the loop parameter or not.

@long2ice
Copy link
Owner

long2ice commented Oct 5, 2021

Fixed

@long2ice long2ice closed this as completed Oct 5, 2021
long2ice added a commit that referenced this issue Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants