Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set echo = True but pool.pyx fill_free_pool create connection without echo parameter #62

Closed
happyelements01 opened this issue May 16, 2023 · 4 comments
Closed

set echo = True but pool.pyx fill_free_pool create connection without echo parameter #62

happyelements01 opened this issue May 16, 2023 · 4 comments

Comments

@happyelements01
Copy link

happyelements01 commented May 16, 2023 •
edited
Loading

Pool init function

https://github.com/long2ice/asyncmy/blob/dev/asyncmy/pool.pyx#LL12C11-L12C11

self._echo not in self._conn_kwargs

Pool fill_free_pool function
https://github.com/long2ice/asyncmy/blob/dev/asyncmy/pool.pyx#L124

i set echo is True, but self._echo is not in self._conn_kwargs

when fill_free_pool function create pool connection without echo parameter？
@happyelements01 happyelements01 changed the title echo == True pool.pyx fill_free_pool create connect without self._echo set echo = True but pool.pyx fill_free_pool create connection without echo parameter May 16, 2023
long2ice added a commit that referenced this issue May 16, 2023
@long2ice
fix: pool echo parameter not apply to create connection. (#62)
958f5dc
@long2ice
Copy link
Owner

fixed

@happyelements01
Copy link
Author

fixed

#62 (comment)

echo without double quotes?

@happyelements01
Copy link
Author

fixed

push the new version to pypi，thanks

@happyelements01
Copy link
Author

fixed

pr

#63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@happyelements01 @long2ice