Fix reading json string #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
long2ice
reviewed
Jul 16, 2024
| @@ -251,7 +251,7 @@ def read_variable_length_string(self): | |||
| length = 0 | |||
| bits_read = 0 | |||
| while byte & 0x80 != 0: | |||
| byte = struct.pack("!B", self.read(1)) | |||
| byte = struct.unpack("!B", self.read(1))[0] | |||
There was a problem hiding this comment.
Thanks! Could you add a test for that?
There was a problem hiding this comment.
@long2ice I can confirm this change also worked for me on my system after getting issues with tables with JSON columns.
It's the same implementation that is done in pymysqlreplication project: https://github.com/julien-duponchelle/python-mysql-replication/blob/main/pymysqlreplication/packet.py#L256
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.