Tagging netgo to be used while compiling with cgo #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olljanat
force-pushed
the
disable-cgo
branch
from
a06cfc8 to
58de78f
Compare
olljanat
changed the title
This was referenced Sep 6, 2022
innobead
requested changes
Sep 19, 2022
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
olljanat
force-pushed
the
disable-cgo
branch
from
567e1ab to
fc52455
Compare
|
@innobead typo fixed, please check again. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
PR is still valid |
|
Because the instance manager has the proxy capability and it is actually the core of the data plane, we need this as well instead of longhorn-engine only. (probably we will reach out to the service in DNS from the instance manager) |
innobead
approved these changes
Nov 14, 2022
Hi @innobead The test PASS, we could merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements suggestion in longhorn/longhorn#4415 (comment) and disable CGO here too like it was done in longhorn-manager by longhorn/longhorn-manager#61Looks that instance-manager needs CGO so switched to alternative solution proposed in longhorn/longhorn#1768 (comment)