Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Snapshot checksum calculation and verification #140

Merged
merged 8 commits into from
Nov 16, 2022

Conversation

derekbit
Copy link
Member

@derekbit derekbit self-assigned this Oct 11, 2022
@derekbit derekbit force-pushed the snapshot-cal branch 5 times, most recently from 2a5b008 to 53f75ed Compare October 17, 2022 15:22
@derekbit derekbit force-pushed the snapshot-cal branch 2 times, most recently from 6a1a629 to 1525f0d Compare October 21, 2022 03:33
@derekbit derekbit marked this pull request as ready for review October 21, 2022 05:46
@derekbit derekbit force-pushed the snapshot-cal branch 2 times, most recently from be4b36f to 129b180 Compare October 28, 2022 11:39
pkg/client/proxy_snapshot.go Outdated Show resolved Hide resolved
pkg/imrpc/proxy.proto Outdated Show resolved Hide resolved
@derekbit derekbit force-pushed the snapshot-cal branch 10 times, most recently from d9971cb to 78ae555 Compare November 2, 2022 16:56
@derekbit derekbit force-pushed the snapshot-cal branch 8 times, most recently from e7ccace to 347d90e Compare November 6, 2022 15:55
@derekbit
Copy link
Member Author

derekbit commented Nov 6, 2022

Please help review. Thank you.
cc @shuo-wu @c3y1huang @innobead

shuo-wu
shuo-wu previously approved these changes Nov 7, 2022
Copy link
Contributor

@shuo-wu shuo-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if there is no doubt about the engine part

@derekbit derekbit force-pushed the snapshot-cal branch 2 times, most recently from bb53f1d to 5c3d8d9 Compare November 11, 2022 14:56
@derekbit
Copy link
Member Author

Will update dependencies if longhorn-engine PR is merged.

@derekbit derekbit requested a review from shuo-wu November 14, 2022 11:17
Longhorn 4210
Longhorn 3198

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 4210
Longhorn 3198

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 4210
Longhorn 3198

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 4210
Longhorn 3198

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 4210
Longhorn 3198

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 4210
Longhorn 3198

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 4210
Longhorn 3198

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 4210
Longhorn 3198

Signed-off-by: Derek Su <derek.su@suse.com>
@derekbit
Copy link
Member Author

This is ready for review.
cc @innobead

@innobead innobead merged commit 36e8461 into longhorn:master Nov 16, 2022
@innobead
Copy link
Member

@derekbit Please create another build, and then update the manifests of longhorn-manager and longhorn repo. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants