Skip to content

Commit

Permalink
fix: change misleading error message to warning level
Browse files Browse the repository at this point in the history
When new replicas are created, the following error messages are emitted in the
longhorn-manager. Empty timestamp is expected in this case, so the error messages
are misleading.

Longhorn 9916

Signed-off-by: Derek Su <derek.su@suse.com>
  • Loading branch information
derekbit committed Dec 6, 2024
1 parent c233d72 commit 1c60b79
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion controller/volume_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ func (c *VolumeController) ReconcileEngineReplicaState(v *longhorn.Volume, es ma
} else {
after, err := util.TimestampAfterTimestamp(transitionTime, r.Spec.LastHealthyAt)
if err != nil {
log.WithError(err).Errorf("Failed to check if replica %v transitioned to mode %v after it was last healthy", r.Name, mode)
log.WithError(err).Warnf("Failed to check if replica %v transitioned to mode %v after it was last healthy", r.Name, mode)
}
if after || err != nil {
r.Spec.LastHealthyAt = now
Expand Down

0 comments on commit 1c60b79

Please sign in to comment.