-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting spdk_tgt log level and flags #2606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is now in conflict. Could you fix it @derekbit? 🙏 |
derekbit
force-pushed
the
issue-7939
branch
4 times, most recently
from
February 20, 2024 10:48
b366b3a
to
b6bc2e2
Compare
Deps are updated and ready for review. |
innobead
requested changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM. Just a few comments. Also, the PR check failed.
Longhorn 7939 Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 7939 Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 7939 Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 7939 Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 7939 Signed-off-by: Derek Su <derek.su@suse.com>
Signed-off-by: Derek Su <derek.su@suse.com>
Updated github.com/golang/protobuf from v1.5.3 to v1.5.4 because of the incompatible change. |
innobead
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#7939
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context
Deps on longhorn/longhorn-instance-manager#402