Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting spdk_tgt log level and flags #2606

Merged
merged 6 commits into from
Mar 10, 2024

Conversation

derekbit
Copy link
Member

Which issue(s) this PR fixes:

Issue longhorn/longhorn#7939

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

Deps on longhorn/longhorn-instance-manager#402

@derekbit derekbit requested a review from a team as a code owner February 18, 2024 16:22
Copy link

mergify bot commented Feb 18, 2024

This pull request is now in conflict. Could you fix it @derekbit? 🙏

@derekbit
Copy link
Member Author

derekbit commented Mar 7, 2024

Deps are updated and ready for review.

Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM. Just a few comments. Also, the PR check failed.

engineapi/instance_manager.go Show resolved Hide resolved
engineapi/instance_manager.go Show resolved Hide resolved
Longhorn 7939

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 7939

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 7939

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 7939

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 7939

Signed-off-by: Derek Su <derek.su@suse.com>
Signed-off-by: Derek Su <derek.su@suse.com>
@derekbit
Copy link
Member Author

derekbit commented Mar 9, 2024

Updated github.com/golang/protobuf from v1.5.3 to v1.5.4 because of the incompatible change.

cc @FrankYang0529

@derekbit derekbit requested a review from innobead March 10, 2024 05:38
@innobead innobead merged commit 00924ce into longhorn:master Mar 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants