Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spdk): support backing image in spdk #35

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ChanYiLin
Copy link
Contributor

ref: longhorn/longhorn#6341

  • Add BackingImageName in SpdkInstanceSpec, so it can create spdk replica with backing image
  • Add proxy api, longhorn-manager will access spdk server through the engine proxy, but it don't have engine involved.
    rpc SPDKBackingImageCreate(SPDKBackingImageCreateRequest) returns (SPDKBackingImageResponse);
    rpc SPDKBackingImageDelete(SPDKBackingImageDeleteRequest) returns (google.protobuf.Empty);
    rpc SPDKBackingImageGet(SPDKBackingImageGetRequest) returns (SPDKBackingImageResponse);
    rpc SPDKBackingImageList(google.protobuf.Empty) returns (SPDKBackingImageListResponse);
    rpc SPDKBackingImageWatch(google.protobuf.Empty) returns (stream google.protobuf.Empty) {}
  • Add spdk api, so we can manage backing image in spdk server
    rpc BackingImageCreate(BackingImageCreateRequest) returns (BackingImage);
    rpc BackingImageDelete(BackingImageDeleteRequest) returns (google.protobuf.Empty);
    rpc BackingImageGet(BackingImageGetRequest) returns (BackingImage);
    rpc BackingImageList(google.protobuf.Empty) returns (BackingImageListResponse);
    rpc BackingImageWatch(google.protobuf.Empty) returns (stream google.protobuf.Empty) {}
    rpc BackingImageExpose(BackingImageGetRequest) returns (BackingImageExposeResponse) {}
    rpc BackingImageUnexpose(BackingImageGetRequest) returns (google.protobuf.Empty) {}

Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing the indentation, we can merge the PR.

protobuf/imrpc/proxy.proto Outdated Show resolved Hide resolved
protobuf/imrpc/proxy.proto Outdated Show resolved Hide resolved
protobuf/imrpc/proxy.proto Show resolved Hide resolved
protobuf/imrpc/proxy.proto Show resolved Hide resolved
protobuf/spdkrpc/spdk.proto Show resolved Hide resolved
@ChanYiLin ChanYiLin force-pushed the LH6341_v2_backing_image branch from f9c284b to f6aa466 Compare December 12, 2024 06:58
ref: longhorn/longhorn 6341

Signed-off-by: Jack Lin <jack.lin@suse.com>
@ChanYiLin ChanYiLin force-pushed the LH6341_v2_backing_image branch from f6aa466 to 14c1143 Compare December 12, 2024 07:01
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit f6797e5 into longhorn:main Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants