Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(1.8.0, 1.7, 1.6): online volume expansion for encrypted volumes #1026

Merged

Conversation

COLDTURNIP
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#9902

What this PR does / why we need it:

Longhorn supports online encrypted volume expansion IF Kubernetes supports.

Special notes for your reviewer:

Online encrypted volume expansion may need to be enabled by cluster admin:

  • Kubernetes v1.29+: this feature is enabled by default
  • Kubernetes v1.25 to v1.28: feature gate is required

In a Kubernetes cluster which supports online encrypted volume expansion, this can be enabled by attaching required parameters in StorageClass.

Additional documentation or context

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit c4daa31
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/676b7e22c4bd760008265543
😎 Deploy Preview https://deploy-preview-1026--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

innobead
innobead previously approved these changes Dec 19, 2024
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, LGTM.

For the source issue, it also needs to be verified by engineering and QA.

derekbit
derekbit previously approved these changes Dec 24, 2024
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit
Copy link
Member

cc @jillian-maroket

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done

content/docs/1.8.0/nodes-and-volumes/volumes/expansion.md Outdated Show resolved Hide resolved
content/docs/1.6.4/nodes-and-volumes/volumes/expansion.md Outdated Show resolved Hide resolved
content/docs/1.7.3/nodes-and-volumes/volumes/expansion.md Outdated Show resolved Hide resolved
@derekbit
Copy link
Member

@COLDTURNIP Please resolve the comments from @jillian-maroket. Thank you.

longhorn/longhorn-9902

Signed-off-by: Raphanus Lo <yunchang.lo@suse.com>
@COLDTURNIP COLDTURNIP dismissed stale reviews from derekbit and innobead via c4daa31 December 25, 2024 03:38
@COLDTURNIP COLDTURNIP force-pushed the 9902-encrypted_vol_k8s_feature_gate_note branch from 853e007 to c4daa31 Compare December 25, 2024 03:38
@derekbit derekbit merged commit 53f6d2e into longhorn:master Dec 25, 2024
6 checks passed
@COLDTURNIP COLDTURNIP deleted the 9902-encrypted_vol_k8s_feature_gate_note branch December 25, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants