Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use longitude-one/wkt-parser, remove php 7.4 & 8.0 support #37

Merged
merged 10 commits into from
May 11, 2023
Merged

Use longitude-one/wkt-parser, remove php 7.4 & 8.0 support #37

merged 10 commits into from
May 11, 2023

Conversation

axi
Copy link
Contributor

@axi axi commented Apr 12, 2023

  • min php version >= 8.1 (as in longitude-one/wkt-parser)
  • use Attributes for tests as doctrine/annotation 2 removed SimpleAnnotationReader
  • on my linux, I had to change some on the tests values to make it pass, not included in this pull request because I found a comment "//TODO: Test should be fixed, distance are differents on Windows and on Linux."

There is probably more to do but that can be a start

@axi axi mentioned this pull request Apr 12, 2023
Closed
ellisgl
ellisgl reviewed Apr 12, 2023
View reviewed changes
.php-cs-fixer.dist.php Outdated
/**
* This file is part of the doctrine spatial extension.
*
* PHP 7.4 | 8.0 | 8.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought we wanted to do 8.1+?

@axi axi changed the title Use longitude-one/wkt-parser Use longitude-one/wkt-parser, remove php 7.4 & 8.0 support Apr 13, 2023
ellisgl
ellisgl approved these changes Apr 13, 2023
View reviewed changes
Copy link

@ellisgl ellisgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

@axi axi temporarily deployed to Test environment April 15, 2023 10:37 — with GitHub Actions Inactive
Alexis Urien added 3 commits April 17, 2023 09:35
Fix codeclimate error ?
a33b3ae 
Generating code coverage report in Clover XML format ... done [00:00.232]
Script phpunit --configuration phpunit.mysql5.7.xml handling the test event returned with error code 1
Error: The process '/usr/local/bin/composer' failed with exit code 1
(node:4044) UnhandledPromiseRejectionWarning: Error: The process '/usr/local/bin/composer' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/paambaati/codeclimate-action/v2.7.5/node_modules/@actions/exec/lib/toolrunner.js:574:25)
    at ExecState.CheckComplete (/home/runner/work/_actions/paambaati/codeclimate-action/v2.7.5/node_modules/@actions/exec/lib/toolrunner.js:557:18)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/paambaati/codeclimate-action/v2.7.5/node_modules/@actions/exec/lib/toolrunner.js:451:27)
    at ChildProcess.emit (events.js:314:20)
    at maybeClose (internal/child_process.js:1022:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5)
(node:4044) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:4044) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Error: 🚨 Coverage run failed!
Test: do not compare float strictly (see https://www.php.net/manual/e…
1fbc420 
…n/language.types.float.php "Floating point precision") so tests will succeed on different linux / windows platforms
Tests: fix 2 more tests
e8924cc
@axi
Copy link
Contributor Author

axi commented Apr 17, 2023 •
edited
Loading

I fixed the unit test errors, should be fine now but need a maintener approval to be run.
Changing codeclimate-action in workflow wasn't necessary finaly... fixing the float equality tests was.

@axi
Copy link
Contributor Author

axi commented Apr 21, 2023

tests should be ok now, I had to modify workflow so forks can be executed (so it need maintener approval to be run)

ellisgl
ellisgl approved these changes Apr 22, 2023
View reviewed changes
Copy link

@ellisgl ellisgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like pretty much auto updated ode and then a couple fixes around tests that look to have passed.

@ca-mk
Copy link

ca-mk commented Apr 23, 2023

+1

@axi axi temporarily deployed to Test environment April 25, 2023 07:03 — with GitHub Actions Inactive
@pimhakkert
Copy link

Hey guys, I just stumbled upon this library, would love to use it, but obviously can't because I'm running the latest doctrine version and PHP 8.1.

When do you think this will be merged into the main branch? Thanks!

@misaert
Copy link

misaert commented Apr 28, 2023

Hey guys, I just stumbled upon this library, would love to use it, but obviously can't because I'm running the latest doctrine version and PHP 8.1.

When do you think this will be merged into the main branch? Thanks!

Hi Pim,

In our side, we used this library with PHP8.1 and Doctrine ORM 2.14.2 without worries.

It just Doctrine Annotations and Doctrine Lexer which are in the previous versions (see #36).

What is your issue?

Regards,

Mickaël

@Alexandre-T Alexandre-T merged commit fbd0dbb into longitude-one:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellisgl ellisgl ellisgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@axi @ca-mk @pimhakkert @misaert @ellisgl @Alexandre-T